Repository navigation
Test build: launcher for Windows (do not merge) - #64
Merged
Merged
Conversation
Set up imports the distro and returns while it is stopped. The next Install click is the first command into that distro. These tests fail while that command is still the 20 second tool check. Co-authored-by: Cursor <cursoragent@cursor.com>
The 3 minute wait ran only when Install itself imported the distro. Set up imports first, so Install saw a listed distro and used the 20 second tool check for the first boot. CI run 42237456986 failed 20.3 seconds after that click. Co-authored-by: Cursor <cursoragent@cursor.com>
The wait, the 20 second tool check, and the test already show the order. A second copy of that fact in a comment is not needed. Co-authored-by: Cursor <cursoragent@cursor.com>
The Windows Install job reached Open my computer and /healthz. It did not click Open Home, Stop, Start, or the update check. Co-authored-by: Cursor <cursoragent@cursor.com>
Runtime 2.0.0 does not write update-check.json. The Mac branch derives that record from the signed head. Windows now writes the same record inside the distro. Co-authored-by: Cursor <cursoragent@cursor.com>
elastos gateway never enters the update controller, so System update inside Home cannot run on Windows. Start home --browser, signal the proved controller on Stop, and start Home again after Update and Undo. Co-authored-by: Cursor <cursoragent@cursor.com>
A valid Runtime update-check.json wins, including offered=false. The signed fallback is written only under ~/.elastos-launcher. Windows Update and Undo do not start Home after a failed Stop or a later Stop. Co-authored-by: Cursor <cursoragent@cursor.com>
The launcher still reads the Runtime update-check.json. That read stops at 16384 bytes, refuses a symlink, and does not follow the final name. Co-authored-by: Cursor <cursoragent@cursor.com>
Runtime 2.0.0 does not write update-check.json. The Windows check stores that result under ~/.elastos-launcher. The end-to-end test reads that file when the Runtime file is absent. Co-authored-by: Cursor <cursoragent@cursor.com>
The end-to-end page cannot load Node modules. The test reads ~/.elastos-launcher/update-check.json from the isolated home, the same place the launcher writes it. Co-authored-by: Cursor <cursoragent@cursor.com>
Stop signaled the process group and fell back to the host pid. The in-distro helper now opens a pidfd, checks the controller identity, and reuses that pidfd. Co-authored-by: Cursor <cursoragent@cursor.com>
A second Stop adopts a new controller and leaves the first helper, its channel directory, and its pidfd alive. The adopted session takes the helper command the test already runs. Co-authored-by: Cursor <cursoragent@cursor.com>
dispose drops the helper on a terminal Stop failure and before a new controller replaces it. TERM and KILL still share one pidfd. The helper already exits when its channel closes or after 60 seconds with no command. Co-authored-by: Cursor <cursoragent@cursor.com>
/proc/net is a symlink on Linux. A Home this launcher started looks foreign when that read comes back empty. Co-authored-by: Cursor <cursoragent@cursor.com>
The facts walker refuses the /proc/net symlink, so the socket table was empty and the launcher treated its own Home as another program. Co-authored-by: Cursor <cursoragent@cursor.com>
The helper used to exit after 60 idle seconds and close that pidfd before the KILL. Co-authored-by: Cursor <cursoragent@cursor.com>
…orwarder The distro socket table does not name the Windows process that answers localhost. A slow Stop must also keep the helper until the command channel closes. Co-authored-by: Cursor <cursoragent@cursor.com>
The listen-table proof left Open with no Home URL. Restore the distro socket check and the synchronous open path. The stop helper still exits when its command channel closes. A late KILL keeps the original pidfd. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Anders needs a Windows app that stays in the background, takes updates, starts and stops the service, and hosts Home. This is a test branch made at his request on 7 Nov. Sasha reviews it later. Do not merge it.
The Install button failed after Set up. Set up imports the Linux environment and returns while that environment is stopped. Install then gave the first command 20 seconds. The first boot takes about 23 seconds.
What changed
Scope
Tradeoffs
Every Windows Install runs
truefirst, with a limit of 3 minutes. A running environment returns when that command finishes. The tool check stays at 20 seconds.Blast Radius
A person who clicks Install on Windows waits until the Linux environment answers. If it never answers, Install fails with the same setup message after up to 3 minutes. Mac and Linux do not use this path.
Verification
trueat 180000 ms.npm teston this branch passed 239 tests, failed 0, and skipped 3. HOME was an empty directory, so this Mac did not start the installed runtime.Made with Cursor