This repository was archived by the owner on Nov 10, 2026. It is now read-only.
Repository navigation
v1.4.4: refuse Brotli responses; Node 24.22.1 for new installs and images - #47
Merged
Merged
Conversation
….4.4) Node.js Oct 2026 security release: CVE-2026-111497 (Brotli decoder OOB write, HIGH) is reachable through any br-encoded fetch response, and Node 20 gets no fix. - Global fetch dispatcher and /api/http stop advertising br and abort br-encoded responses before decoding (works on any Node version). - Docker images node:24.22.1; installers/bootstrap install Node 24; CI on 24.22.1; enm-server fallback v24.22.1 (was EOL v23.10.0). - test:unit lists test files so it runs on Node 24. - engines stays >=20.18.0 so existing nodes are unaffected.
npm 11 (bundled with Node 24) refuses npm ci when the lockfile lacks other platforms' optional packages. Adds 52 @esbuild/@img/@napi-rs entries; no existing version changes.
Node 24.22.1 dropped it from its CA store, so assert the filter removes exactly the distrusted roots the running Node ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to the Node.js October 2026 security releases. The worst issue for PC2 is CVE-2026-111497 (HIGH), a Brotli decoder out-of-bounds write that any
br-encodedfetchresponse can reach. The fixes are in 24.22.1, 22.23.4 and 26.12.1 only. Node 20, which the installers have put on every Linux and Jetson node, gets no fix. The in-app updater never changes a node's Node runtime, so this has to be fixed in pc2-node's own code to reach existing nodes.1. Brotli guard (works on any Node version)
pc2-node/src/utils/refuseBrotli.ts, an undici interceptor that:brfromAccept-Encoding, so normal servers reply with gzip or identity,Content-Encoding: branyway, before Node decodes it.fetchdispatcher (installOutboundTlsPolicy) and into/api/http's per-request pinned dispatcher.fetchis the only path.bris refused, andbris never sent. Live checks against Cloudflare, Google, GitHub, npm, both supernodes, zzz and ipfs.ela.city all return 200 over gzip.2. Node 24 for new installs and images
node:24.22.1-alpinefor the pc2-node, docker/pc2 and web-gateway images, andnode:24.22.1-bookworm-slimfor enm-server. The tags are pinned exactly because the floatingnode:24-alpinetag hadn't been repointed yet.install-arm.shandsupernode-bootstrap.shusesetup_24.xand require Node 24 or newer.install-wsl.shandstart-local.shusenvm install 24and default to 24.test:unitnow lists the test files, because Node 24'snode --testdoesn't accept a bare directory. It runs the same 60 tests on 20 and 24.enginesstays at>=20.18.0, so existing Node 20 nodes don't get install warnings.Version 1.4.4 and a CHANGELOG entry.
Do not merge until it has been tested on zzz.ela.city running Node 24.22.1.
Also in this PR
pc2-node/package-lock.jsongains 52 missing optional platform entries (esbuild, sharp,@napi-rs/canvas). npm 11, which ships with Node 24, refusesnpm ciwithout them. No existing version changes.tls-trust.test.jsno longer assumes Node bundles emSign ECC G3, because Node 24.22.1 dropped it.Testing
/optand linked into/usr/local/bin, so pc2, npm and the in-app updater all use 24.22.1.canvaswas rebuilt for Node 24. sqlite, node-pty and node-datachannel load unchanged.Accept-Encoding: gzip, deflate.canvas2.11.2 has no Node 24 Windows build, so tsc can't resolve it. Supported Linux installs compile it, because the ARM and WSL installers add the Cairo headers. Moving to@napi-rs/canvas(already the planned Phase 2 follow-up) would fix this.