This repository was archived by the owner on Nov 10, 2026. It is now read-only.
Repository navigation
v1.4.5: install patched Node on update, verify TLS in gateway and scripts, pin actions - #48
Merged
Merged
Conversation
…ipts, pin actions - scripts/install-node.sh: nodejs.org Node 24.22.1 (SHA-256 checked) into /opt, linked into /usr/local/bin; used by update.sh, install-arm.sh, supernode bootstrap - update.sh: Node upgrade step + pm2 daemon restart; strip NODE_TLS_REJECT_UNAUTHORIZED=0 from .env - pc2-node: ignore leftover NODE_TLS_REJECT_UNAUTHORIZED=0 at boot - web-gateway: peer/DHT requests without decompression, supernode certs verified - remove curl -k / rejectUnauthorized:false from scripts and tooling - pin GitHub Actions to SHAs; permissions on main.yml; install-node CI job Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…erServer's live copy) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until tested on zzz.
v1.4.5 finishes the Node.js October security work and removes the last places that skip certificate checks.
Node.js upgrade on update
scripts/install-node.sh: if thenodeon PATH is unpatched (below 24.22.1 / 22.23.4 / 26.12.1), it installs the official nodejs.org 24.22.1 build, checked againstSHASUMS256.txt, into root-owned/optand links it into/usr/local/bin. It exits 2 and leaves Node unchanged on nvm, macOS, 32-bit OS, missing sudo, or a binary that doesn't run (old glibc). To roll back, remove the four links.update.shruns it before npm install and rebuild, then runspm2 updateif the Node version changed, so pc2 actually runs on the new Node.PC2_SKIP_NODE_UPGRADE=1skips the step.install-arm.shand the supernode bootstrap use the same installer instead of NodeSource, whose 24.x channel still has the unpatched 24.22.0.install-node-scriptupgrades a NodeSource Node 20 + pm2 install on x64 and arm64.TLS
NODE_TLS_REJECT_UNAUTHORIZED=0at boot. That also covers nodes updated in-app, which never run update.sh.update.shstrips it from.envand no longer copies it forward.ecosystem.config.cjsalways sets it to1.lib/peer-request.js(http/https, never decompressed, Brotli refused). Elacity supernode IPs are verified assupernode.ela.city. Gossip between InterServer and Contabo was failing certificate checks before this. Registry sync is off on both (REGISTRY_SYNCis unset), so neitherregistry.jsonis written to.curl -kis gone from the bootstrap,deploy-supernode.sh,setup-wireguard-client.shandpc2-diagnose.sh. Each now uses--resolve supernode.ela.city:443:<ip>(or the real domain); every form was checked live and returns verify=0.cluster-backfill.mjsandwave8-supernode-live-verify.mjsno longer disable verification.CI
uses:are pinned to commit SHAs (same commits the major tags point to today), andmain.ymlnow declares its permissions.Not changed
enginesstays at>=20.18.0: nodes that can't upgrade (nvm, 32-bit) would only get warnings.tests/api-testerandtools/comment-writerdev tools are left as they are; they aren't shipped to or run on nodes.Tested
better-sqlite3build (wrong ABI); CI does a clean install.