Conversation
bech32_encode() allows an encoded address of up to 90 characters, as BIP-173 specifies, but wally_addr_segwit_from_bytes() encodes into a 90 byte stack buffer. When the address is exactly 90 characters long the NUL terminator is written one byte past the end of the buffer. Any 30 character hrp with a 32 byte version 0 program hits the boundary, as does any other combination whose encoded length is 90. Size the buffer for the maximum length plus the terminator, matching what the blech32 encoder already does, and add the boundary case to the bech32 test vectors so it is exercised in both directions. Found by bitcoinfuzz.
Merged
Contributor
|
Hi @brunoerg Merged with rebase/changelog item removed (as that's for the previous release and will be updated before the next release). Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bech32_encode() allows an encoded address of up to 90 characters, as BIP-173 specifies, but wally_addr_segwit_from_bytes() encodes into a 90 byte stack buffer. When the address is exactly 90 characters long the NUL terminator is written one byte past the end of the buffer.
Any 30 character hrp with a 32 byte version 0 program hits the boundary, as does any other combination whose encoded length is 90.
Size the buffer for the maximum length plus the terminator, matching what the blech32 encoder already does, and add the boundary case to the bech32 test vectors so it is exercised in both directions.