Repository navigation
feat: Forever map markers - #2681
Merged
EllesmereGaming merged 8 commits intoOct 17, 2026
Merged
Conversation
Jetro974
force-pushed
the
forever-map-markers
branch
from
October 14, 2026 19:26
fbcd922 to
d271f25
Compare
…t or an exit leads to
# Conflicts: # EllesmereUILocales/_keys.txt
# Conflicts: # EllesmereUIForeverEssentials/EllesmereUIForeverEssentials_Camelot.toc # EllesmereUILocales/_keys.txt # EllesmereUIOptions/EUI_ForeverEssentials_General_Options.lua
…gh once per pin out of combat
# Conflicts: # EllesmereUIForeverEssentials/EllesmereUIForeverEssentials_Camelot.toc # EllesmereUILocales/_keys.txt # EllesmereUILocales/frFR.lua # EllesmereUIOptions/EUI_ForeverEssentials_General_Options.lua # EllesmereUIOptions/EUI_ForeverEssentials_Options.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Show Map Markers to Forever Essentials > General > World Map (WoW Forever only, off by default). Travel markers appear by zoom level:
The cog turns each set off (all shown by default once the option is on). Hovering a marker names it; touching markers share one tooltip. Clicking a marker prints its map pin link in chat, like
/waydoes, led by its icon and kind ("Dungeon: The Deadmines (Main Entrance)", "Path from Elwynn Forest to Westfall", "Boat to Menethil Harbor"...); clicking the link places the game's pin. Markers on world and continent maps link to the zone they stand in.A right click on a marker goes on to the map (back out a level), as anywhere else on it.
How was it tested?
WoW Forever client, in game:
python3 .tools/guardrails.pypasses;_keys.txtis regenerated.Screenshots
Checklist
TAXI_NODE_STATUS_CHANGEDwhile flight points show; pins are pooled and rebuilt only when the map or the toggles change; no OnUpdate, no timersMapCanvasDataProviderMixinprovider and our own pin frames on a frame of ours under the canvas. The left click only prints aworldmaplink, Blizzard's own link handler places the pin. Right clicks pass through every pin to the map:SetPassThroughButtonsis called once per pin when it is created, never in combat (a pin created in combat gets it when combat ends)