Repository navigation
Swing Timer: spark width, overhang and per-weapon colors - #2733
Merged
EllesmereGaming merged 2 commits intoOct 17, 2026
Merged
EllesmereGaming merged 2 commits into
EllesmereGaming merged 2 commits into
Conversation
Show Spark gets a Spark cog: - Width: the spark's width (default 8, the size every EUI spark uses). - Overhang: how far the spark reaches past the bar's top and bottom, in screen pixels (default 0). An overhanging spark leaves the bar's clip for a clip of its own, built on first use, that still cuts it at the bar's ends. - Main Hand / Off Hand / Ranged Color: each weapon's spark color. Unset, a spark stays white and a combined off hand's spark keeps its fill color, so existing profiles look the same.
main's _keys.txt lists 1308 keys but its header still says 1306 (a merge left it stale), so the locale-keys check fails on every Lua PR. Regenerated with .tools/extract-locale-keys.sh; no key lines change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Swing Timer's Show Spark toggle gets a Spark cog:
Existing profiles look the same until one of these is changed.
How was it tested?
Tested in game on the WoW Forever client (the Swing Timer only exists there).
.tools/guardrails.pypasses.Screenshots
New cogwheel in the Swing Timer options:


Default Spark (same as before):

Default sizes recolored red (subtle):

Minor overhang (5px red):

15 overhang:

24 overhang (max value lol):

Max width:

Different colors on ranged and melee displayed:

Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames. Only the Swing Timer's own frames are touched.