Repository navigation
fix(locale): translate leftover English labels - #2795
Merged
EllesmereGaming merged 1 commit intoOct 19, 2026
Merged
EllesmereGaming merged 1 commit into
EllesmereGaming merged 1 commit into
Conversation
These labels went straight to SetText / AddDoubleLine, or were joined with a number before L() saw them, so they stayed English on every locale. Wrap the literals in L() at the call site and use Lf() for the joined ones. The tooltip duplicate checks now look for the same L() key as the line they guard, so a translated line is not added twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On non-English clients these stay English: the
M+ Score:/Mount:tooltip lines; Damage MetersUnknown,(N overkill)and theDamage Meter Nmovers; the Minimap friends tooltip (Whisper,Invite,No friends online,...and N more); AuraBuff RemindersUnknown; the Raid & Party Frames preview titles and intro popup.Cause
They go straight to
SetText/AddDoubleLine, or are joined with a number beforeL()sees them.Fix
Literals are wrapped in
L()at the call site; joined strings useLf(), with color codes kept outside the key. The tooltip duplicate checks now look for the sameL()key as the line they guard (as Item Level does), so a translated line is not added twice.Notes
_keys.txtis left out on purpose to avoid conflicts; please rerun.tools/extract-locale-keys.shwhen merging. zhTW is in locale(zhTW): translate 60 new keys, unify Shifter and prune 5 dead ones #2796.Testing
Compiles under Lua 5.1;
.tools/guardrails.pypasses. Not yet loaded in-game.Checklist