Skip to content

Keep developer evidence capturing with automatic retention - #7

Merged
ElliotDrel merged 1 commit into
mainfrom
codex/evidence-retention
Oct 19, 2026
Merged

ElliotDrel merged 1 commit into
mainfrom
codex/evidence-retention

Conversation

@ElliotDrel

@ElliotDrel ElliotDrel commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

What Changed and Why

Issue: Developer evidence permanently stopped saving at its 256 MiB quota. The production store contained 2,363 run folders dating back to before the Rust release; correction logs continued while new screenshots/sidecars were rejected.

Why this change was necessary: The previous policy protected all existing evidence and had no automatic retention. Its cached reservations could also remain stale after failed writes or manual cleanup.

New status quo: Under the existing shared mutex, reconcile actual usage on pressure and remove oldest eligible whole-run folders toward 192 MiB before admitting new evidence. Protect the current run, recent incomplete runs, backups, custom content, and reparse points. Skip locked candidates and retain their manifests until payload removal completes. Log pruning and at most one storage warning per run. Expired/partly pruned replay evidence gets an explicit diagnostic. Ordinary JSONL logs and exported replay cases are preserved.

Verification

  • GitHub Rust checks passed: lint, Dev/Prod regressions, optimized build, native startup/resource smoke, and candidate packaging. Local Clippy also passed with warnings denied.

  • Windows: 27 Rust unit tests plus the DPI resource test passed with production features. Seven retention tests cover continued writes after pressure, stale counters, active/backup protection, abandoned runs, quota/path checks, locked files, and junctions.

  • Seven targeted Python checks passed, including missing/partially pruned payload diagnostics. Full pytest suite not run: pytest is unavailable.

  • Claude Opus 5.5 medium performed two independent reviews; actionable findings were addressed and retested. git diff --check passed.

  • Local recovery moved 155 older completed runs (64.16 MiB) to a separate local archive without deleting evidence, restoring roughly 64 MiB of headroom. No clipboard/GUI actions or application restart. A new live capture has not been forced.

After merge

Published v0.13.1 at 9fece49. Release CI, including fresh-installer validation, passed. The existing installed app updated through its native restart flow to 0.13.1 and reported Up to date. Settings/encrypted-key fingerprints, daily logs and archived evidence were preserved; no new update error events. The merged worktree/branch and release build artifacts are cleaned up. No forced clipboard or editor test was performed.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 22b7617d-ac9c-4caa-81eb-4bc53a22f88d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T18:51:40.705406Z 72d1b9f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ElliotDrel
ElliotDrel merged commit 588aaf2 into main Oct 19, 2026
3 checks passed
@ElliotDrel
ElliotDrel deleted the codex/evidence-retention branch October 19, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant