Conversation
StatusParser required the mailbox name to be double-quoted (`STATUS "INBOX" (...)`). RFC 3501 allows the name to be sent as an atom, and Dovecot does so (`STATUS INBOX (...)`), so the regex never matched and MESSAGES/UNSEEN/UIDNEXT were silently left at 0 for every mailbox. The regex now accepts either a quoted string or an atom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
StatusParserrequired the mailbox name to be double-quoted:RegExp(r'(STATUS "[^"]+?" )(.*)'). RFC 3501 allows the mailbox to be sent as an atom, and Dovecot does so (* STATUS INBOX (MESSAGES 231 UNSEEN 5 ...)), so the regex never matched andmessagesExists/messagesUnseen/uidNextwere silently left at 0 for every mailbox on such a server.Fix
The regex accepts either a quoted string or an atom:
(STATUS (?:"[^"]+?"|[^ (]+) )(.*). The existing test for a quoted name containing brackets still passes.Tests
New test in
status_parser_test.dartforSTATUS INBOX (MESSAGES 231 UNSEEN 5 UIDNEXT 4392). Fails againstmain.