Conversation
StatusParser had no case for HIGHESTMODSEQ, so a CONDSTORE server that answers `STATUS ... (HIGHESTMODSEQ n)` (RFC 7162 section 3.1.6), whether asked for it or volunteering it, hit the default branch and the value was printed as unexpected rather than stored. Mailbox already has a highestModSequence field, populated by SELECT; STATUS now fills it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
StatusParserhad no case forHIGHESTMODSEQ. A CONDSTORE server that answersSTATUS ... (HIGHESTMODSEQ n)(RFC 7162 section 3.1.6), whether asked for it viaReturnOption.status(['HIGHESTMODSEQ'])or volunteering it, hit thedefault:branch: the value was printed as unexpected and discarded.Mailbox.highestModSequencewas only ever populated by SELECT, so a client using STATUS to decide whether a mailbox needs a sync could not do so.Fix
Add the
HIGHESTMODSEQcase and store it inbox.highestModSequence.Tests
New test in
status_parser_test.dart. Fails againstmain.