Repository navigation
docs(spatial): address review of R-tree page enumeration (follow-up to #205) - #218
Merged
mrdevrobot merged 1 commit intoOct 15, 2026
Merged
Conversation
- VacuumOptions.RebuildIndexes: drop the stale "Spatial indexes are not rebuilt" sentence; spatial indexes are now rebuilt like the others. - RTreeIndex.CollectAllPages: document that the walk does not take the index lock and which lock each caller holds. - RTreeIndex.CollectAllPages: Debug.Fail when a page is reached twice (cycle or shared child); the seen set still keeps release builds finite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mrdevrobot
approved these changes
Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #205 review (#189).
VacuumOptions.RebuildIndexes: replaced "Spatial indexes are not rebuilt." with "Spatial (R-tree) indexes are rebuilt the same way."RTreeIndex.CollectAllPages: the doc now says the walk doesn't take the index lock, and which lock each caller holds:DropIndexholds the index manager's_lock, which index insert/update/delete also take;Debug.Fail. Theseenset still keeps release builds finite, and the page is counted once.No behaviour change in release builds. Spatial/Vacuum/RTree/Geo tests: 105 passed.
Spatial_DeleteHalf_OfASplitTree_ReturnsExactlyTheSurvivorstimed out once under parallel load and passed 3/3 on its own. NoDebug.Failfired in Debug runs, including the half-deleted trees.🤖 Generated with Claude Code