Repository navigation
M3: scene format version 1 and luxpath check - #3
Merged
Merged
Conversation
TOML scenes (docs/scene-format.md) with photometry and emergency output, luminaires, escape routes, open and high-risk areas, points of emphasis; unknown fields refused, errors located by line and column. `luxpath check` reports illuminance per element with its assumptions and exits 0/1/2/3 (pass, fail, input error, cannot verify; always 3 until M4). Three example scenes with synthetic photometry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
M3: scenes and
luxpath check.docs/scene-format.md), in TOML:luxpath check scene.tomlprints min/mean/max and max/min per route, area and point, followed by the assumptions and the disclaimer.examples/: an L-shaped corridor, an open-plan office, and a plant room with a high-risk area and wall-mounted luminaires. Their synthetic photometry is generated from formulas listed inexamples/photometry/README.md.luxpath-rulesevaluates a scene;luxpath-reportwrites the text report.How you verified it
cargo xtask ci, natively (macOS) and in the local Linux container. Merged on the local checks (hosted CI unavailable).apps/luxpath-cli/tests/check.rs);crates/scene/src/tests.rs).Life safety (AGENTS.md §2)
Never panic (AGENTS.md §3)
Provenance (AGENTS.md §1)
Records
parity/features.toml: the scene features shipped,cli.checkpartialdocs/status.md,docs/gaps.md(row 5 closed),docs/roadmap.md,ROADMAP.mdlog, README status