Skip to content

feat: keep next-pass review action visible above the dock - #12

Open
henrychong-ai wants to merge 2 commits into
EveryInc:mainfrom
henrychong-ai:agent/floating-review-ready-control
Open

feat: keep next-pass review action visible above the dock#12
henrychong-ai wants to merge 2 commits into
EveryInc:mainfrom
henrychong-ai:agent/floating-review-ready-control

Conversation

@henrychong-ai

@henrychong-ai henrychong-ai commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Replace the bottom-only next-pass action with one compact, count-aware Review ready cards control anchored above the Dock.

  • keep the action visible throughout long review queues
  • show it only on To review while readyNextPass > 0
  • preserve exactly one next-pass mutation surface
  • block duplicate activation and expose an accessible pending state
  • move focus and scroll to the newly revealed pass after activation
  • preserve the existing next-pass API, domain, and schema unchanged

Design

Floating Review ready cards control on desktop

Floating Review ready cards control on mobile

Validation

  • pnpm check: 225 passed, 1 environment-gated Supabase test skipped, 0 failed
  • Bun 1.3.11 randomized-order regression run, including DOM tests before API Origin checks
  • App integration coverage spans visibility, duplicate activation, pending state, success, focus, editor focus preservation, failure, and retry
  • pnpm build
  • pnpm tend:build
  • pnpm tend:smoke
  • pnpm tend:package
  • git diff --check
  • final control component and Dock integration match the verified desktop/mobile design artefacts

Changes:
- replace the bottom next-pass action with a dock-anchored control
- preserve duplicate guards focus recovery and accessible pending state
- document the design and include final desktop and mobile previews

Files: 10 staged, 10 documented
@henrychong-ai

henrychong-ai commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

CI diagnosis, corrected after reproducing the failure: the pinned Bun version was not the cause. test/app-card-disposition.test.tsx registered HappyDOM globally and never restored Bun's native web globals. HappyDOM's Request drops the Origin header from Hono's in-process app.request, and Linux ran that DOM test before test/api-routes.test.ts, so the security test received 200 instead of 403. Commit c63b4ea scopes HappyDOM to the App test with beforeAll/afterAll; randomized Bun 1.3.11 runs now pass with the DOM test before the API test. Local validation: 225 passed, 1 environment-gated skip, 0 failed, plus build, audit, binary smoke, and package.

@henrychong-ai
henrychong-ai marked this pull request as ready for review July 17, 2026 07:27
Changes:

- exercise visibility, pending, success, focus, failure, and retry paths
- restore HappyDOM globals so API Origin checks remain isolated

Files: 4 staged, 4 documented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant