Skip to content

feat(export): add --toolbox-platform for container run - #68

Merged
fmenesesg merged 1 commit into
mainfrom
feat/toolbox-platform
Sep 25, 2026
Merged

fmenesesg merged 1 commit into
mainfrom
feat/toolbox-platform

Conversation

@fmenesesg

Copy link
Copy Markdown
Collaborator

Proposed change

Phase B of issue #65 / SDD change macos-apple-silicon-toolbox-platform: add opt-in --toolbox-platform / THREESCALE_TOOLBOX_PLATFORM so toolbox container run can pass --platform (e.g. linux/amd64 on Apple Silicon). Empty/whitespace omits the flag (no auto-default). Native --toolbox-binary path ignores platform.

Follows Phase A (PR #66 / release v0.4.5 darwin/arm64 assets).

Related: #65

Type of change

  • Bug fix (non-breaking)
  • New feature
  • Tests / CI
  • Documentation
  • Integration cross-repo (3scaleextract ↔ apishift)
  • Breaking change

RHCL checklist

  • Tests added or updated (go test ./...) — CommandRunner mock argv tests + config flag/env binding
  • CI does not introduce -DskipTests without justification
  • No secrets in diff (tokens, kubeconfigs, OIDC secrets)
  • rhcl-ai docs updated if export/import contract changes — N/A
  • PR description and docs in English
  • Tested in local lab if applicable (seed → export → analyze) — live Mac+toolbox out of band; unit argv mocks cover merge gate

Test plan

PR B review checklist

  • Empty/whitespace → no --platform token
  • No auto-default to linux/amd64 on any host
  • Argv order run --rm --platform … then cert mounts/image
  • Native binary path ignores platform
  • No Goreleaser / wider matrix / PATH-wrapper product code
  • Docs state run-only issuance + pre-pull must match platform
  • Diff limited to internal/config/, internal/cli/cli.go, internal/export/toolbox{,_test}.go, README.md, CHANGELOG.md

Local verification

  • go test ./internal/config/ ./internal/export/ ./internal/cli/ -count=1
  • go test ./... -count=1
  • Authored churn ~208 lines (under 400-line review budget)

Additional information

  • SDD: Phase B of macos-apple-silicon-toolbox-platform (stacked-to-main after Phase A / v0.4.5)
  • Rollback: revert this PR; empty platform restores prior run --rm argv

Made with Cursor

Opt-in THREESCALE_TOOLBOX_PLATFORM / --toolbox-platform inserts
--platform after run --rm so Apple Silicon hosts can force linux/amd64
without auto-defaulting empty values.

Co-authored-by: Cursor <cursoragent@cursor.com>
@fmenesesg
fmenesesg requested a review from pcastelo as a code owner September 25, 2026 20:47
@fmenesesg fmenesesg added the type:feature New feature or enhancement label Sep 25, 2026
@fmenesesg
fmenesesg merged commit cfab354 into main Sep 25, 2026
1 check passed
@fmenesesg
fmenesesg deleted the feat/toolbox-platform branch September 25, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant