feat(export): add --toolbox-platform for container run - #68
Merged
Merged
Conversation
Opt-in THREESCALE_TOOLBOX_PLATFORM / --toolbox-platform inserts --platform after run --rm so Apple Silicon hosts can force linux/amd64 without auto-defaulting empty values. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Phase B of issue #65 / SDD change
macos-apple-silicon-toolbox-platform: add opt-in--toolbox-platform/THREESCALE_TOOLBOX_PLATFORMso toolbox containerruncan pass--platform(e.g.linux/amd64on Apple Silicon). Empty/whitespace omits the flag (no auto-default). Native--toolbox-binarypath ignores platform.Follows Phase A (PR #66 / release v0.4.5 darwin/arm64 assets).
Related: #65
Type of change
RHCL checklist
go test ./...) — CommandRunner mock argv tests + config flag/env binding-DskipTestswithout justificationTest plan
PR B review checklist
--platformtokenlinux/amd64on any hostrun --rm --platform …then cert mounts/imageinternal/config/,internal/cli/cli.go,internal/export/toolbox{,_test}.go,README.md,CHANGELOG.mdLocal verification
go test ./internal/config/ ./internal/export/ ./internal/cli/ -count=1go test ./... -count=1Additional information
macos-apple-silicon-toolbox-platform(stacked-to-main after Phase A / v0.4.5)run --rmargvMade with Cursor