test(core): freeze the clock in the default minSlice coroutine test - #780
Merged
Merged
Conversation
Exoridus
enabled auto-merge (squash)
September 26, 2026 06:26
Bundle ReportChanges will increase total bundle size by 20.79MB (61.27%) ⬆️
ℹ️ *Bundle size includes cached data from a previous commit Affected Assets, Files, and Routes:view changes for bundle: site-server-esmAssets Changed:
App Routes Affected:
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoroutineSystem > defaults minSlice to a 64th of the bound frame targetreadbudget.timeRemaining()against the real clock. At a 120 Hz frame target the default slice is about 130 µs, so a CI runner that stalls for longer betweenpreFrameand the coroutine's first read sees 0 and failstoBeGreaterThan(0). It failed that way on the unit lane of #777 without any related change.The test now freezes
performance.now()for the frame, so the coroutine sees the full slice, and it asserts that value exactly (toBeCloseTo(1 / 120 / 64)) instead of the old> 0 && <= limitwindow. A broken default still fails: a zero floor reads 0, a wrong divisor reads a different value.