Repository navigation
feat: allow the window to be maximized - #5
Merged
Merged
Conversation
The maximize button was disabled and the analysis view stayed 840px wide, so a larger window could not show the chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
讓 StorViz 視窗可以最大化。issue #1 的截圖裡,標題列的最大化按鈕是停用的。
src-tauri/tauri.conf.json:maximizable改為 true,resizable也改為 true。macOS 的綠色按鈕和 Windows 的最大化都需要視窗可調整大小,否則系統仍會把按鈕關掉。預設仍是 840×630,最小尺寸也鎖在這組,避免縮得比現在的版面還小。src/app/analyze/page.tsx:分析結果外層從固定w-[840px]改成w-full。圖表欄是1fr,檔案列表維持 260px,最大化之後圖會跟著變大,不會留一塊空白。首頁本來就是置中,放大後仍置中。沒有改掃描或圖的計算。
相關 issue
closes #1
怎麼驗
tauri.conf.json的視窗設定,以及分析頁外層寬度。檢查清單
tool/check/commits.sh:這個 repo 沒有這支腳本flutter analyze/flutter test:這是 Tauri / Next,不適用gh pr checks。本機沒有把整個 Tauri app 跑起來