Repository navigation
Deploy Checklist: New Expensify 2024-08-12 #47219
Description
Activity
Uhhhh where are the deploy blockers 🤣
- Aah, this is being discussed internally here: https://expensify.slack.com/archives/C07J32337/p1723478316279429
Some PRs got added to the checklist but aren't in staging yet. Examples:
- #46949: Fix Results, Loading and Empty state Search pages #47164
- Optimize isPendingRemove function #47228
I'm removing them from the checklist and I'll add them here- I also brought this up in Slack hereUpdate: Now it's looking like those PRs might actually be in staging even though they're not in the staging branch? So I added them back to the checklist
Checking off #47159 b/c it was somehow checked off in the previous checklist & now the root cause PR (#42302) is in Prod 😅
Regression is 41% progress
Unchecked PRs:
#44940 Validation pending in iOS android desktop and mweb
#45151 Validation pending in Desktop
#46425 Validation pending in iOS
#46556 #46556 (comment)
#46575 Validation pending in iOS
#46627 Validation pending in iOS and desktop
#46640 Validation pending in iOS
#46787 Validation pending in iOS and desktop
#46795 Validation pending in iOS and desktop
#46860 Validation pending in mweb and desktop
#46869 Validation pending in mweb
#46931 All platforms are pending validation
#47056 #47056 (comment)Demoted #47246
Also demoting #47265
Regression is at 50%
Unchecked PRs:#44940 Validation pending in iOS android desktop and mweb
#45151 Validation pending in Desktop
#46425 Validation pending in iOS
#46556 #46556 (comment)
#46575 Validation pending in iOS
#46627 Validation pending in iOS and desktop
#46640 Validation pending in iOS
#46787 Validation pending in iOS and desktop
#46795 Validation pending in iOS and desktop
#46860 Validation pending in mweb and desktop
#46931 Validation pending in iOS android desktop and mweb
#47056 #47056 (comment)
and cpsDemoted #47251 b/c report fields are behind a beta
^ similar w/ #47252
5 remaining items
#46556 (comment) handled in #47289 but doesn't need to be CP'd b/c the fix fixed a bug in prod 😅
Checking off #44940 b/c it's not available for most users on NewDot yet
Checking off #46795 b/c bug found is also on prod, so not related to this PR
Checked off #47050 b/c it was an old blocker that was closed w/ the labels, and just reopened for payment... But it's not a blocker for this latest release
#47056 QA fail is NAB since it didn't introduce a new bug, it just didn't full fix the bug that already exists on prod
checking off #46944 b/c it looks good!
#46787 testing well so checking it off
Demoted #47242, which means also checking off #46931 - the potential bugs will still be considered by @youssef-lr when he's online, but shouldn't be considered blockers
Regression is complete.
We are validating the CP now.
Reacted by Alex BeamanEverything looking good! let's ship!
Release Version:
9.0.19-11Compare Changes: production...staging
This release contains changes from the following pull requests:
github.event.release.tag_nameinstead ofgithub.ref_namefor releases #47250stagingbranch instead ofmainfor pre-release #47253gh release upload#47266\to fix iOS release upload #47267Internal QA:
SWITCH_REPORTevent #46966 - @mountinyDeploy Blockers:
Deployer verifications:
cc @Expensify/applauseleads