Add DualEntry support for vendor matching - #100678
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@Beamanator ready for review now! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f27f58c496
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
hmm failing jest tests don't seem related, eh? I"ll retry them |
Explanation of Change
DualEntry now supports the expense vendor picker, Vendors page, merchant rules, and vendor-name lookup. These features use the same eligible vendors as export. DualEntry follows Rillet in the source order and requires the
vendorMatchingbeta and a configured connection.This PR extends the vendor-matching support from the merged Rillet PR #100542. Current
mainis merged into this branch.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/679020
PROPOSAL:
Tests
Prerequisite: Use a workspace with the
vendorMatchingbeta enabled, DualEntry connected and configured, and at least one active vendor available to the selected company.More Features page
Manual vendor selection and search
Automatic vendor matching
Inactive-vendor error
Credit Card Misc fallback on export
Prerequisite: a DualEntry workspace with no default vendor set under Accounting > Export, and no vendor named
Credit Card Miscin DualEntry.Credit Card Miscvendor with no company set, and that the exported expense uses it. The workspace default vendor stays empty.Credit Card Miscvendor and no second one gets created.Offline tests
NA
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari