Skip to content

Remove custom agent beta gates - #100875

Merged
puneetlath merged 4 commits into
mainfrom
puneet/remove-custom-agent-beta-app
Sep 10, 2026
Merged

Remove custom agent beta gates#100875
puneetlath merged 4 commits into
mainfrom
puneet/remove-custom-agent-beta-app

Conversation

@puneetlath

@puneetlath puneetlath commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Custom agents and agent rules are available to all users, but the App still gates their entry points on the customAgent Betatify flag. This removes that runtime beta constant and makes the existing enabled behavior unconditional across Settings, workspace rules, promotional content, and product marketing. The product-facing Beta badges remain unchanged because custom agents should still be labeled as Beta. Tests now cover the feature's default availability instead of configuring a beta value.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/677842
PROPOSAL: N/A

Tests

  1. Sign in with a regular, non-agent account.
  2. Open Settings and verify the Agents row is visible with its Beta badge.
  3. Open Settings > Agents directly and verify the page loads instead of displaying Not Found.
  4. Open Workspace > Rules and verify the agents banner and Agent Rules section are visible.
  5. In Supportal > Betatify, add the rulesRevamp beta to the test account.
  6. Open Workspace > Rules and verify the Agents tab and Create agent rule option are visible.
  7. Open the AI features promotional modal and verify the custom agents page is included with its Beta badge.
  8. Sign in as an agent account and verify the Agents Settings row remains hidden.
  • Verify that no errors appear in the JS console

Offline tests

  1. Disconnect from the network.
  2. Open Settings and verify the Agents row remains visible with its Beta badge.
  3. Open a cached workspace's Rules page and verify the agents entry points remain visible.
  4. Reconnect and verify normal navigation resumes.

QA Steps

  1. Sign in with a regular, non-agent account.
  2. Open Settings and verify the Agents row is visible with its Beta badge.
  3. Open Settings > Agents directly and verify the page loads instead of displaying Not Found.
  4. Open Workspace > Rules and verify the agents banner and Agent Rules section are available.
  5. In Supportal > Betatify, add the rulesRevamp beta to the test account.
  6. Open Workspace > Rules and verify the Agents tab is available.
  7. Open the new-rule menu and verify Create agent rule is available.
  8. Open the AI features promotional modal and verify the custom agents page is included with its Beta badge.
  9. Sign in as an agent account and verify the Agents Settings row remains hidden.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A: No visual styling changes.

Android: mWeb Chrome

N/A: No visual styling changes.

iOS: Native

N/A: No visual styling changes.

iOS: mWeb Safari

N/A: No visual styling changes.

MacOS: Chrome / Safari CleanShot 2026-09-10 at 14 59 53@2x CleanShot 2026-09-10 at 15 00 24@2x CleanShot 2026-09-10 at 15 01 10@2x CleanShot 2026-09-10 at 15 01 48@2x

@puneetlath
puneetlath requested review from a team as code owners September 10, 2026 18:27
@melvin-bot
melvin-bot Bot requested review from hoangzinh and removed request for a team September 10, 2026 18:28
@melvin-bot

melvin-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team and heyjennahay and removed request for a team September 10, 2026 18:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30ab147879

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/settings/useSettingsNavigationMenuData.ts
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 91.52% <ø> (ø)
...tMarketingWindow/ProductMarketingWindowManager.tsx 98.00% <ø> (-0.04%) ⬇️
src/pages/settings/Agents/AgentsPage.tsx 75.00% <100.00%> (-1.70%) ⬇️
...rc/pages/settings/useSettingsNavigationMenuData.ts 100.00% <100.00%> (ø)
...es/workspace/rules/AgentRules/AddAgentRulePage.tsx 0.00% <ø> (ø)
...s/workspace/rules/AgentRules/EditAgentRulePage.tsx 0.00% <ø> (ø)
src/pages/workspace/rules/PolicyRulesPage.tsx 90.00% <100.00%> (-0.25%) ⬇️
src/pages/workspace/rules/tabs/RulesGeneralTab.tsx 0.00% <0.00%> (ø)
...rc/pages/workspace/rules/PolicyRulesPageRevamp.tsx 2.20% <0.00%> (ø)
src/pages/workspace/rules/RulesNewPage.tsx 0.00% <0.00%> (ø)
... and 1 more
... and 8 files with indirect coverage changes

@robertjchen robertjchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@puneetlath
puneetlath merged commit f86d3d9 into main Sep 10, 2026
40 of 43 checks passed
@puneetlath
puneetlath deleted the puneet/remove-custom-agent-beta-app branch September 10, 2026 19:05
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.76-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Yes — help site changes are required. Draft PR: #100904

Why: this PR makes Agents unconditional for every account, but Create-and-Use-Custom-Agents.md still tells members Agents are an opt-in beta and that they must contact Concierge to request access.

What changed in the docs (1 file, 4 lines):

Section Before After
## Who can use Agents "available through an open beta program… contact Concierge to request access" Available to every account, no request needed; the Beta badge signals ongoing improvement, not gated access; the option is hidden only while Copiloting into an agent's account
FAQ: Why can't I see Agents in my Account settings? "Agents are in Beta and may not be enabled on your account yet" Hidden only while Copiloting into an agent's account — this is now the sole gate, per useSettingsNavigationMenuData.ts:152 (if (!isAgentAccount))
Verification and scope

UI labels checked against a running build on this branch (so the docs match exact capitalization):

  • Account settings shows an Agents row with a Beta badge, with no beta enabled.
  • Settings > Agents loads (no Not Found) and the create button is New agent.
  • Workspace Rules shows the Agent rules section with a Beta badge and an Add agent rule button, plus the agents promo banner.

The Beta badges are intentionally kept in the docs, matching your note that custom agents stay labeled Beta.

No other articles need changes. I checked every article under docs/articles/new-expensify/ai-agents/ plus workspaces/Workspace-Rules.md. Only Create-and-Use-Custom-Agents.md gated availability on the beta. Create-Agent-Rules.md already scopes access correctly ("You must be a Workspace Admin" and "Rules must be enabled for the workspace") and never mentioned a beta, so it is accurate as-is.

Applied docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: headings unchanged (both already start with a question word), all UI labels bolded with exact UI capitalization, no new links added.


@puneetlath, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · no recording available

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.76-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants