Docs updates for E/A#99747 signed Amount sorting and Total spend netting - #100900
Docs updates for E/A#99747 signed Amount sorting and Total spend netting#100900MelvinBot wants to merge 1 commit into
Conversation
…pend page Co-authored-by: Bartłomiej Obudziński <BartekObudzinski@users.noreply.github.com>
MelvinBot
added
the
HelpDot
|
@MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@twisterdotcom Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done — this PR is now Ready for review. PullerBear picked it up and requested
I could not verify anything in a browser on this run — the web test environment failed to come up — so the article's claims rest on the static analysis recorded in the PR description, not a live check of the Spend page. Checks are green except |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b55322d7bf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 2. Click the **Amount** column header to sort from largest to smallest. | ||
| 3. Click the **Amount** column header again to reverse the order. |
There was a problem hiding this comment.
On mobile and medium-width layouts, these steps cannot be followed because SearchTableHeader returns without rendering any column headers (src/components/Search/SearchTableHeader.tsx:573-619). Sorting remains available through the Display menu's Sort by and Sort order controls, so label the current instructions as the large-screen web flow and add the distinct narrow/mobile flow; otherwise those users are told to click an Amount header that does not exist.
Useful? React with 👍 / 👎.
|
please address the codex comments @BartekObudzinski |
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
|
@MelvinBot please apply this to Codex is right about the sorting steps. On narrow layouts the sort lives behind the Display icon. One thing worth getting right in the steps: Sort by and Sort order apply separately. Replace this block: ## How to sort the Amount column on the Spend page
1. On the **Spend** page, select **Expenses**.
2. Click the **Amount** column header to sort from largest to smallest.
3. Click the **Amount** column header again to reverse the order.
The **Amount** column header is only available when your results are shown as a table. When you group your results, this column header reads **Total** instead of **Amount**.with this: ## How to sort the Amount column on the Spend page
On a wide screen:
1. On the **Spend** page, select **Expenses**.
2. Click the **Amount** column header to sort from largest to smallest.
3. Click the **Amount** column header again to reverse the order.
On mobile, or in a narrow browser window, the column headers aren't shown, so sort from the **Display** menu instead:
1. On the **Spend** page, select **Expenses**.
2. Tap the **Display** icon.
3. Tap **Sort by**, select **Amount**, then tap **Apply**.
4. To change the direction, tap the **Display** icon again, tap **Sort by**, tap **Sort order**, select **Descending** (largest to smallest) or **Ascending** (smallest to largest), then tap **Apply**.
The **Amount** column is only sortable when your results are shown as a table. When you group your results, this column reads **Total** instead of **Amount**.The last paragraph changes from "column header is only available" to "column is only sortable", because the narrow path has no header but the column is still sortable there.
|
|
|
3 participants
Explanation of Change
Documents the two user-visible behaviors that #99747 fixed on the Spend page, in
docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md:Amountcolumn sorting. Before that PR, the Amount column's sort key dropped the sign for credits and refunds, so a -$4,000 credit sorted among the +$4,000 expenses. It now sorts by the signed value each row displays. Two new sections cover how to sort the column and where negative amounts land in the order, because "why is this credit in the middle of my positive expenses" is a natural search and the article had no sorting content at all.Total spendnetting. Before that PR, the selection footer summed magnitudes, so selecting a +$100 expense and a -$100 credit reported $200. It now nets them to $0.00. The existing "What the total spend footer shows" section described what the total covers but not how credits behave in it, so one clarifying sentence with a worked example was added there.No existing sentence was factually wrong before this change, so this is a gap-filling clarification rather than a correction. Nothing else in
docs/articlesreferenced Amount-column sorting or the footer's handling of negative amounts.Authoring notes:
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md: task-based##headings starting with a question word, bolded UI labels in Sentence case, no new###or#headings, no screenshot placeholders (the surrounding text is sufficient and a screenshot would just mirror it).Spend,Expenses, andReportswere confirmed on dev NewDot web.Total spendiscommon.totalSpendand renders in the footer viaSearchPageFooter. The Amount column header resolves toiou.amount(Amount), and tocommon.total(Total) when results are grouped — that fallback is called out in the article. Click-to-sort and click-again-to-reverse matchSortableHeaderText, where the first press sets descending order.#headings,###subheadings, nointernalScope). I left those alone to keep this diff scoped to the behavior change; restructuring the article is separate work.npm run spell-changedpasses on the changed file.Fixed Issues
$ #99918
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — this PR only changes help site markdown under
docs/articles.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@BartekObudzinski, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.