Docs updates for E/A#99912 Home Concierge prompt box mention and emoji suggestions - #100902
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#99912 Home Concierge prompt box mention and emoji suggestions#100902MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…Home Co-authored-by: Gabriel Cyganek <GCyganek@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #99912, which added
@mentionand:emojisuggestions to the Concierge prompt box on Home and fixed suggestions rendering behind the right-hand Concierge panel.The Concierge prompt box on Home was not documented on the help site at all, so there was nowhere for the new suggestion behavior to live. This adds it to
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md:@, selecting a suggestion, and the web keyboard behavior (arrow keys, Enter / Tab to insert, Escape to dismiss, prompt not sent while the list is open).:and inserting a suggestion.keywordsandinternalScopeto match.Every UI string in the article was checked against the running app on web rather than taken from the code: the wide-screen placeholder Ask Concierge to analyze your expenses or get support, the narrow-screen placeholder Ask Concierge anything, the Add attachment menu item, the Send icon, and the top-right Help icon that opens Concierge in the panel on the right.
No other help site article needed changes — the rest of the PR (the
useComposerSuggestionsextraction, the suggestions portal z-index, and the viewport-bottom helpers) is internal refactoring with no user-facing documentation impact.One screenshot is suggested as a non-rendered
<!-- SCREENSHOT: -->placeholder, perdocs/HELP_AUTHORING_GUIDELINES.mdsection 8.Fixed Issues
$ #99550
PROPOSAL: N/A
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Suggested review (docs-only change, no app code):
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
This PR only changes help site markdown under
docs/articles. No app behavior changes.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Reference captures used to verify the documented behavior and UI strings against the running app on web (not part of the docs change itself).
@GCyganek, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.