Skip to content

Docs updates for E/A#98368 Editing existing manual and odometer distance expenses - #100905

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-98368-require-gps-map-entry
Draft

Docs updates for E/A#98368 Editing existing manual and odometer distance expenses#100905
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-98368-require-gps-map-entry

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #98368, which made an existing manual or odometer distance expense editable even when the workspace requires map or GPS distance. The creation guard previously fired on edit too, so members were blocked from changing the distance on expenses they created before the workspace turned the requirement on.

The Require GPS or map entry setting was not documented on the help site at all, so neither the rule nor this new exception to it was discoverable. This PR documents both.

docs/articles/new-expensify/workspaces/Set-distance-rates.md (admin-facing)

  • Added How to require GPS or map entry for distance expenses — what the setting does and the steps to enable it on Distance rates > Settings.
  • Added What happens to existing manual and odometer expenses when you require GPS or map entry — states that the setting applies to new expenses only and that pre-existing manual and odometer expenses stay editable until approved.
  • Added two FAQ entries and expanded keywords / internalScope.

docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md (member-facing)

  • Added a note to the manual and odometer creation sections explaining that those options are unavailable when the workspace has Require GPS or map entry enabled, and what the blocking message says.
  • Added a paragraph to How to edit an existing Distance expense covering the behavior this PR shipped.
  • Added two FAQ entries and expanded keywords.

Scope note: commuter exclusions ("Exclude commutes") is the other setting that forces map or GPS distance, and it is also touched by #98368. It is deliberately not documented here because it is still gated behind the commuterExclusions beta (src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx) and is not visible to general users yet. The "Why can't I turn off Require GPS or map entry?" FAQ describes the locked-toggle behavior generically so the article stays accurate without naming a beta feature. It should be expanded once commuter exclusions goes GA.

UI verification: the labels used here were checked against dev NewDot on web — the Distance rates page, its Settings button, and the Require GPS or map entry toggle with the subtitle "Manual and odometer entry will be disabled." The blocking modal copy ("This workspace requires either map-based or GPS-tracked distance expenses." with a Got it button) comes from src/languages/en.ts and was not screen-confirmed.

Fixed Issues

$ #98223
PROPOSAL: N/A — documentation follow-up to #98368

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@fedirjh, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…dometer distance expenses

Co-authored-by: Fedi Rajhi <fedirjh@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 10, 2026 23:03
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants