Docs updates for E/A#98368 Editing existing manual and odometer distance expenses - #100905
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#98368 Editing existing manual and odometer distance expenses#100905MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…dometer distance expenses Co-authored-by: Fedi Rajhi <fedirjh@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #98368, which made an existing manual or odometer distance expense editable even when the workspace requires map or GPS distance. The creation guard previously fired on edit too, so members were blocked from changing the distance on expenses they created before the workspace turned the requirement on.
The Require GPS or map entry setting was not documented on the help site at all, so neither the rule nor this new exception to it was discoverable. This PR documents both.
docs/articles/new-expensify/workspaces/Set-distance-rates.md(admin-facing)keywords/internalScope.docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md(member-facing)keywords.Scope note: commuter exclusions ("Exclude commutes") is the other setting that forces map or GPS distance, and it is also touched by #98368. It is deliberately not documented here because it is still gated behind the
commuterExclusionsbeta (src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx) and is not visible to general users yet. The "Why can't I turn off Require GPS or map entry?" FAQ describes the locked-toggle behavior generically so the article stays accurate without naming a beta feature. It should be expanded once commuter exclusions goes GA.UI verification: the labels used here were checked against dev NewDot on web — the Distance rates page, its Settings button, and the Require GPS or map entry toggle with the subtitle "Manual and odometer entry will be disabled." The blocking modal copy ("This workspace requires either map-based or GPS-tracked distance expenses." with a Got it button) comes from
src/languages/en.tsand was not screen-confirmed.Fixed Issues
$ #98223
PROPOSAL: N/A — documentation follow-up to #98368
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@fedirjh, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.