[No QA] Docs updates for E/A#100607 auto-generated government rate icon and currency change - #100906
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#100607 auto-generated government rate icon and currency change#100906MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
… behavior Co-authored-by: Nabi <nabi-ebrahimi@users.noreply.github.com>
Contributor
Author
|
@nabi-ebrahimi I couldn't add you as an assignee — GitHub rejects the assignment because your permission on Please review the files changed and confirm they reflect the current behavior. Then post a new comment saying |
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://e4bb3377.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #100607, which fixed the lightning bolt icon disappearing from an unedited government distance rate after a workspace default currency change.
Reviewing that change against
docs/articles/new-expensify/workspaces/Set-distance-rates.mdsurfaced three gaps, all fixed here in that one article:1. Wrong supported-currency list (factual error). The article listed
USD, CAD, GBP, AUD, or NZDin three places. NZD is not supported —CONST.CUSTOM_UNITS.GOVERNMENT_RATE_CURRENCY_TO_COUNTRYmaps onlyUSD → US,CAD → CA,GBP → GB, andAUD → AU. Corrected toUSD, CAD, GBP, or AUDthroughout.2. Wrong toggle label. The article said Auto-update government rate (singular) in five places. The live UI label, verified on the workspace Distance rates > Settings page, is Auto-update government rates (plural). Corrected everywhere, including the FAQ heading.
3. The behavior #100607 restored was never documented. Added two sections and three FAQ entries covering:
All UI labels used here were verified against the live web UI: page heading Distance rates, button Add rate, settings rows Unit, Default category, Auto-update government rates, Require GPS or map entry, Track tax, and unit options Kilometers and Miles.
The article passes
npm run spell-changedand the HelpDot structural rules indocs/HELP_AUTHORING_GUIDELINES.md: one#title plus# FAQ,##for every section, no###, and every heading task-based.Fixed Issues
$ #98962
PROPOSAL:
Source PR: #100607
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@nabi-ebrahimi, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.