Skip to content

[No QA] Docs updates for E/A#100607 auto-generated government rate icon and currency change - #100906

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsGovernmentRateCurrencyChange
Draft

[No QA] Docs updates for E/A#100607 auto-generated government rate icon and currency change#100906
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsGovernmentRateCurrencyChange

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #100607, which fixed the lightning bolt icon disappearing from an unedited government distance rate after a workspace default currency change.

Reviewing that change against docs/articles/new-expensify/workspaces/Set-distance-rates.md surfaced three gaps, all fixed here in that one article:

1. Wrong supported-currency list (factual error). The article listed USD, CAD, GBP, AUD, or NZD in three places. NZD is not supported — CONST.CUSTOM_UNITS.GOVERNMENT_RATE_CURRENCY_TO_COUNTRY maps only USD → US, CAD → CA, GBP → GB, and AUD → AU. Corrected to USD, CAD, GBP, or AUD throughout.

2. Wrong toggle label. The article said Auto-update government rate (singular) in five places. The live UI label, verified on the workspace Distance rates > Settings page, is Auto-update government rates (plural). Corrected everywhere, including the FAQ heading.

3. The behavior #100607 restored was never documented. Added two sections and three FAQ entries covering:

  • The lightning bolt icon that marks an auto-generated rate, and its tooltip This rate is auto-generated.
  • That the icon is removed only when an admin edits the rate amount, Start date, or End date — not when Expensify converts the rate between Miles and Kilometers on its own. This is exactly the distinction fix: preserve lightning bolt icon after government rate currency change #100607 implemented.
  • What happens when the workspace default currency changes: a new government rate is added for the new country, the workspace Unit switches to the unit that country publishes in (Miles for the United States and Great Britain, Kilometers for Canada and Australia), and earlier government rates are converted to that unit while keeping their lightning bolt icon.

All UI labels used here were verified against the live web UI: page heading Distance rates, button Add rate, settings rows Unit, Default category, Auto-update government rates, Require GPS or map entry, Track tax, and unit options Kilometers and Miles.

The article passes npm run spell-changed and the HelpDot structural rules in docs/HELP_AUTHORING_GUIDELINES.md: one # title plus # FAQ, ## for every section, no ###, and every heading task-based.

Fixed Issues

$ #98962
PROPOSAL:

Source PR: #100607

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@nabi-ebrahimi, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

… behavior

Co-authored-by: Nabi <nabi-ebrahimi@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 10, 2026 23:05
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 10, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

@nabi-ebrahimi I couldn't add you as an assignee — GitHub rejects the assignment because your permission on Expensify/App is read, and only users with write access are assignable. Tagging you here instead.

Please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

@github-actions github-actions Bot changed the title Docs updates for E/A#100607 auto-generated government rate icon and currency change [No QA] Docs updates for E/A#100607 auto-generated government rate icon and currency change Sep 10, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://e4bb3377.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants