Skip to content

Keep the page an RHP was opened from underneath it - #100917

Draft
mukhrr wants to merge 3 commits into
Expensify:mainfrom
mukhrr:fix/100874
Draft

Keep the page an RHP was opened from underneath it#100917
mukhrr wants to merge 3 commits into
Expensify:mainfrom
mukhrr:fix/100874

Conversation

@mukhrr

@mukhrr mukhrr commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Six RHP screens opened from a chat, an expense or Home were pinned to a Settings or Home pane in the relation maps, so the first in-app click swapped the background page and closing the RHP landed there.

The app download links screen becomes a dynamic route, like the contact methods list, so its background follows the base path. The other screens move to deeplink-only relations (SETTINGS_TO_RHP_DEEPLINK, HOME_TO_RHP_DEEPLINK, same pattern as SEARCH_TO_RHP_DEEPLINK), consulted only when state is built from a path. A fresh load still lands on the owning page, an in-app click keeps the screen underneath.

Fixed Issues

$ #100874
PROPOSAL: #100765 (comment)

Tests

Preconditions: wide web layout. Case 1 needs an account that has never signed in to the mobile app. Cases 3 to 6 need the matching Concierge message or Home item on the account (trial ended, broken personal card connection, signer info requested).

  1. Open an expense without a receipt and click Download the app under "Other ways to add receipts". Verify the RHP opens over the expense and the URL keeps the expense path.
  2. Close the RHP. Verify you are back on the expense.
  3. Open an IOU chat where you owe money, click Pay > Pay with Expensify > Personal bank account. Verify the chat stays behind the RHP, then close it and verify you are back on the chat.
  4. In the Concierge chat click Add payment card. Verify the chat stays behind the RHP, then close it and verify you are back on the chat.
  5. In the Concierge chat click Log into your bank in the broken card connection message. Verify the chat stays behind, then close it and verify you are back on the chat.
  6. In the chat with the signer info message click Enter signer info. Verify the chat stays behind, then close it and verify you are back on the chat.
  7. On Home click Fix on the personal card connection item. Verify Home stays behind, then close it and verify you are back on Home.
  8. Go to Account > About > App download links, refresh the page and press back. Verify you land on About.
  9. Refresh the page while any of the RHPs from steps 3 to 7 is open. Verify it lands on the Wallet, Subscription or Home page that owns it, as before.
  • Verify that no errors appear in the JS console

Offline tests

Steps 1 to 9 behave the same offline, the change only affects how the navigation state is built and involves no network requests.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Six RHP screens opened from a chat, an expense or Home were pinned to a
Settings or Home central pane in the relation maps, so the first in-app
click swapped the background page and closing the RHP landed there.

The app download links screen becomes a dynamic route so its background
follows the base path, like the contact methods list. The other screens
move to deeplink-only relations, consulted only when state is built from
a path, so a fresh load still lands on the owning page while an in-app
click keeps whatever full screen is underneath.
@mukhrr
mukhrr requested review from a team as code owners September 11, 2026 02:24
@melvin-bot
melvin-bot Bot requested review from dmkt9 and joekaufmanexpensify and removed request for a team September 11, 2026 02:24
@melvin-bot

melvin-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 11, 2026 02:24
@mukhrr
mukhrr marked this pull request as draft September 11, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant