Keep the page an RHP was opened from underneath it - #100917
Draft
mukhrr wants to merge 3 commits into
Draft
Conversation
Six RHP screens opened from a chat, an expense or Home were pinned to a Settings or Home central pane in the relation maps, so the first in-app click swapped the background page and closing the RHP landed there. The app download links screen becomes a dynamic route so its background follows the base path, like the contact methods list. The other screens move to deeplink-only relations, consulted only when state is built from a path, so a fresh load still lands on the owning page while an in-app click keeps whatever full screen is underneath.
melvin-bot
Bot
requested review from
dmkt9 and
joekaufmanexpensify
and removed request for
a team
September 11, 2026 02:24
mukhrr
marked this pull request as draft
September 11, 2026 02:27
Open
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Six RHP screens opened from a chat, an expense or Home were pinned to a Settings or Home pane in the relation maps, so the first in-app click swapped the background page and closing the RHP landed there.
The app download links screen becomes a dynamic route, like the contact methods list, so its background follows the base path. The other screens move to deeplink-only relations (
SETTINGS_TO_RHP_DEEPLINK,HOME_TO_RHP_DEEPLINK, same pattern asSEARCH_TO_RHP_DEEPLINK), consulted only when state is built from a path. A fresh load still lands on the owning page, an in-app click keeps the screen underneath.Fixed Issues
$ #100874
PROPOSAL: #100765 (comment)
Tests
Preconditions: wide web layout. Case 1 needs an account that has never signed in to the mobile app. Cases 3 to 6 need the matching Concierge message or Home item on the account (trial ended, broken personal card connection, signer info requested).
Offline tests
Steps 1 to 9 behave the same offline, the change only affects how the navigation state is built and involves no network requests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari