Skip to content

Blank personal info RHP displayed while adding bank account #100920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dukenv0307 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −3
Open

Blank personal info RHP displayed while adding bank account #100920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a67028
Blank personal info RHP displayed while adding bank account
dukenv0307 Sep 10, 2026
ada4e35
Merge branch 'main' into fix/100517
dukenv0307 Sep 11, 2026
1dc9625
update comments
dukenv0307 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libs/actions/BankAccounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,10 @@ function getOnyxDataForConnectingVBBAAndLastPaymentMethod(policyID?: string, las

/**
* Submit Bank Account step with Plaid data so php can perform some checks.
*
* @returns true when redirected to the manual flow (Chase Plaid dummy numbers).
*/
function connectBankAccountWithPlaid(bankAccountID: number, selectedPlaidBankAccount: PlaidBankAccount, policyID: string | undefined) {
function connectBankAccountWithPlaid(bankAccountID: number, selectedPlaidBankAccount: PlaidBankAccount, policyID: string | undefined): boolean {
const isChaseBank = selectedPlaidBankAccount.bankName?.toLowerCase() === CONST.BANK_NAMES.CHASE;
if (bankAccountID === CONST.DEFAULT_NUMBER_ID && isChaseBank) {
Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {
Expand All @@ -457,7 +459,7 @@ function connectBankAccountWithPlaid(bankAccountID: number, selectedPlaidBankAcc
accountNumber: '',
routingNumber: '',
});
return;
return true;
}

const parameters: ConnectBankAccountParams = {
Expand All @@ -473,6 +475,7 @@ function connectBankAccountWithPlaid(bankAccountID: number, selectedPlaidBankAcc
};

API.write(WRITE_COMMANDS.CONNECT_BANK_ACCOUNT_WITH_PLAID, parameters, getVBBADataForOnyx());
return false;
}

/**
Expand Down
7 changes: 6 additions & 1 deletion src/pages/ReimbursementAccount/USD/BankInfo/BankInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function BankInfo({onBackButtonPress, onSubmit, policyID}: BankInfoProps) {
if (plaidAccountIDChanged) {
deletePaymentBankAccount(bankAccountID, undefined);
}
connectBankAccountWithPlaid(
const redirectedToManual = connectBankAccountWithPlaid(
plaidAccountIDChanged ? CONST.DEFAULT_NUMBER_ID : bankAccountID,
{
[BANK_INFO_STEP_KEYS.ROUTING_NUMBER]: data[BANK_INFO_STEP_KEYS.ROUTING_NUMBER] ?? '',
Expand All @@ -93,6 +93,11 @@ function BankInfo({onBackButtonPress, onSubmit, policyID}: BankInfoProps) {
},
policyID,
);

// No bank account was created. Stay on this step so the manual form can create it before advancing.
if (redirectedToManual) {
return;
}
}
markSubmitting();
};
Expand Down
Loading