[No QA] Update help docs for NetSuite REST + OAuth 2.0 (Releases 2-4) - #100921
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Update help docs for NetSuite REST + OAuth 2.0 (Releases 2-4)#100921MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Sasha Kluger <sakluger@users.noreply.github.com>
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://ea14d353.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Release 4 of Move NetSuite to the REST API makes REST + OAuth 2.0 the default for new NetSuite connections. This updates the Connect to NetSuite help article so it documents that flow instead of the SOAP + token-based authentication flow.
What changed and why:
NetSuiteTokenInputPagewhen thenetSuiteOAuthbeta is on.docs/HELP_AUTHORING_GUIDELINES.md(one#title plus# FAQ, task-based##headings, noStep Nheadings) anddocs/HELPSITE_NAMING_CONVENTIONS.md. All non-auth NetSuite prep (expense reports, expense categories, transaction forms, tax groups) is preserved — it's unaffected by the transport change.UI labels and NetSuite menu paths were taken from
src/languages/en.ts(workspace.netsuite.tokenInput.formSteps) and the connect flow components rather than written from memory. One thing worth a human check before merge: the Account ID lookup path is still documented as Setup > Integration > Web Services Preferences, carried over from the previous version of the article — please confirm that's still the right path for a REST-based connection.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/657177
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari