Paginate live to-do searches instead of rendering every cached row

[TMisiukiewicz]

Explanation of Change

The four to-do searches (Submit, Approve, Pay, Export) render from a live Onyx scan. That scan returns every matching row at once, so an account with a large local cache paints hundreds of rows on the first render.

useSearchSnapshot now accepts a visibleRowLimit that truncates data after the sort and the optimistic stabilization, so each page holds the rows at the top of the current order rather than whatever order the scan produced. chartData, filteredData and the footer count and total still read the full set, so selection, the chart and the totals are unchanged.

<Search> derives the cap from the snapshot cursor as max(50, isLoading ? offset : offset + 50) instead of keeping its own page state. The live early return is gone from fetchMoreResults, so reaching the end of the list fires a normal Search request with the same offset and totals params as any other search. Since offset is written to the snapshot optimistically when the request fires, the cap stays on the old offset while isLoading is set. The rows hold still and the existing load-more skeleton shows until the response lands.

SearchResultsProvider no longer forces isLoading: false for live searches, which is what lets that skeleton know a page is in flight. The full-page skeleton stays suppressed by the shouldUseLiveData gates already in <Search> and useSearchLoadingState.

Related to #100409, which deletes the live to-do path altogether. This one keeps it and paginates it, so the offline behaviour of the live scan survives.

Fixed Issues

$
PROPOSAL:

Tests

1. Sign in with an account that has more than 50 reports awaiting approval cached locally.
2. Open Search and select Needs approval. Verify only the first 50 rows render.
3. Scroll to the bottom of the list. Verify a load-more skeleton appears, a Search request goes out with the next offset, and 50 more rows render once it resolves.
4. Repeat steps 2-3 for Ready to pay, Awaiting export and the submit bucket.
5. Change the sort column and sort order on a to-do search. Verify the list re-sorts, starts again from the first page, and shows no duplicate rows.
6. Approve one report from the list. Verify the row is removed and the footer count and total update.
7. Verify the footer count and total still reflect the full local set rather than only the rendered page.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline and open Needs approval. Verify the first page of live rows renders and no loading skeleton is stuck on screen.
2. Scroll to the bottom while offline. Verify no request is queued and the list does not blank out.
3. Go back online and scroll to the bottom again. Verify the next page loads.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Search/hooks/useSearchSnapshot.ts	86.95% <100.00%> (+0.14%)	⬆️
src/components/Search/index.tsx	57.81% <100.00%> (+0.27%)	⬆️
src/components/Search/SearchResultsProvider.tsx	79.31% <0.00%> (ø)
... and 10 files with indirect coverage changes

[github-actions]

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100941.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7ad4cba-a523acd-89ba04140e69abdc50cbab2252230849045671f4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7ad4cba-a523acd-b5c183ca2afc949dd54e4f28c2c48b9ec6382917/index.html

Web 🕸️
https://100941.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀