Extract Expensify card lookup into pure function - #100945
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
dylanexpensify
left a comment
There was a problem hiding this comment.
Refactor, no product input needed
Explanation of Change
Prep slice 3 of 4 decomposing #99062 (Route Search previews through the shared LHN alternate text pipeline). This slice only extracts the Expensify-card lookup out of
useGetExpensifyCardFromReportActioninto a pure function, ahead of the actual pipeline change that needs to call it from non-React code.Fixed Issues
$ #98958
PROPOSAL:
Tests
Cannot test this manually as I don't have access to Expensify Cards feature
npm run test tests/unit/useGetExpensifyCardFromReportActionTest.tsOffline tests
N/A — pure refactor of an Onyx-collection lookup, no network interaction.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari