Generalize convertToDisplayStringWithoutCurrency for any locale

[sosek108]

Explanation of Change

Prep slice 2 of 4 decomposing #99062 (Route Search previews through the shared LHN alternate text pipeline). This slice only generalizes the currency formatting helper, ahead of the actual pipeline change.

No behavior change: every existing caller goes through the unchanged …EnLocale wrapper and still formats with en.

Fixed Issues

$ #98958
PROPOSAL:

Tests

1. Open a report with expenses and confirm amounts render with the same formatting as before (no currency symbol where that variant is used).
2. Switch the app locale (Settings > Preferences > Language) and confirm formula-computed report titles still format with en, unchanged.

• Verify that no errors appear in the JS console

Offline tests

N/A — pure refactor of currency string formatting, no network interaction.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-09-11.o.14.12.51.mov

[sosek108]

@MelvinBot review
@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 6f88df66ad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[melvin-bot]

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[MelvinBot]

🤖 Review: LGTM — the refactor is behavior-preserving. Two non-blocking follow-ups below.

The extracted convertToDisplayStringWithoutCurrencyForLocale is a line-for-line match with the block deleted from the provider (same sanitize → decimals → convertToFrontendAmountAsInteger → formatToParts → filter order), formatToParts already accepts Locale | undefined, the …EnLocale wrapper still pins en, and the useCallback deps at index.tsx:59-63 are unchanged. Typecheck, ESLint, knip, and all 8 test jobs pass; the only red checks are the reviewer checklist and independent approval.

1. A third copy of this logic is still hand-rolled

reportAttributes.ts:280-293 duplicates the exact same body against preferredLocale — its own comment says it "mirror[s] the provider's implementations". Now that the helper takes a locale, that block collapses to a single call, and the file already imports from CurrencyUtils, so there's no new dependency. If it's out of scope for this slice, fine — but the mirror will silently drift the moment someone changes one and not the other. (The test helper is a fourth copy, lower stakes.)

2. No test covers a non-en locale for the symbol-less formatter

That's the one capability this slice adds. convertToDisplayString already has an ES-locale case, but the convertToDisplayStringWithoutCurrency block only asserts malformed-currency safety and nothing about locale. Worth one test.each asserting ('EUR', 250000) → 2500,00 under CONST.LOCALES.ES, so slice 3 can't regress comma/period placement without failing.

---

What I checked

• Byte-compared the extracted function against the deleted provider block — identical, including the two explanatory comments about forced decimals.
• Confirmed formatToParts(locale: Locale | undefined, …) in NumberFormatUtils/index.ts, and that its USD RangeError fallback still applies.
• Confirmed the dropped formatToParts import left no other use in the provider (format is still used by convertToDisplayString).
• Confirmed no new import cycle: the provider already imported sanitizeCurrencyCode / convertToFrontendAmountAsInteger from CurrencyUtils, and CurrencyUtils only imports the provider's types file type-only.
• Grepped every convertToDisplayStringWithoutCurrency* call site — the two Formula.ts callers (602, 628) still go through the …EnLocale wrapper, so formula-computed report titles stay locale-independent as the PR claims.

I could not drive this in a browser this run, so the "no behavior change" conclusion is from static analysis and CI, not a live locale switch. Someone should still run test step 2 (switch language, confirm formula report titles stay en) by hand.

---

view run

[MelvinBot]

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

[joekaufmanexpensify]

No product review needed.