Skip to content

[No QA] Docs updates for E/A#98662 Tabbed Rules and Workflows help site updates - #101010

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsRulesRevampBetaRemoval
Draft

[No QA] Docs updates for E/A#98662 Tabbed Rules and Workflows help site updates#101010
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsRulesRevampBetaRemoval

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#98662 removed the rulesRevamp beta, so the revamped Rules and Workflows pages are now the default for every workspace and the pre-revamp screens are gone. The help site still described the old single-page layouts, so this PR updates the affected articles under docs/articles to match the shipped UI.

What changed in the product, and how the docs now reflect it:

  • Rules is a tabbed page. The tabs are General, Card restrictions, Expense defaults, Field requirements, Flag for review, and Agents. Workspace-Rules.md was rewritten around those tabs, with the row labels that actually ship on the General tab (Flag expenses older than, Flag expenses above amount, Flag receipt line items, Require receipts, Require fields for all expenses, Cash expenses, Billable expenses, Require company cards for all purchases, eReceipts, Attendee tracking, Public receipt visibility).
  • Rules is no longer Control-only. canPolicyAccessFeature now allows Rules on Collect as well as Control, but on Collect only Require fields for all expenses and Billable expenses work — everything else prompts a Control upgrade. The plan wording in Workspace-Rules.md was corrected accordingly.
  • Workflows is a tabbed page. The tabs are Submissions, Approvals, Payments, and Advanced. Report-level rules (Prevent self-approvals, Auto-approve compliant reports, Auto-pay approved reports) now live on Advanced, so they moved out of Workspace-Rules.md and into Workspace-Workflows.md, and Add-Approvals.md navigation was updated to name the tab.
  • Category settings moved to Rules. The category page no longer has Default tax rate, Flag amounts over, Require receipts over, Require itemized receipts over, or Require fields. Those are now rules created from the Category rules section or the matching Rules tab, which Create-expense-categories.md now documents.
  • Require categories / require tags moved to Rules. The toggles in Categories > Settings and Tags > Settings are gone; requiring a category or tag is now the Require fields for all expenses rule on the General tab. Require-tags-and-categories-for-expenses.md was rewritten around that.
  • Default spend categories moved to Rules. MCC defaults are now rules on the Expense defaults tab with a condition of Merchant type is, so both Require-tags-and-categories-for-expenses.md and Create-expense-categories.md point there instead of Categories > Settings.
  • Merchant rules and Expensify Card spend rules moved into tabs. The Merchant section is now the Expense defaults tab and the Spend section is now the Card restrictions tab, so Workspace-Merchant-Rules.md, Import-Merchant-Rules.md, and Expensify-Card-Spend-Rules.md were updated.
  • Prohibited expenses is now Flag receipt line items on the General tab, so Prohibited-Expense-Rule.md was rewritten around the shipped label. It also now lists Gift card purchases and states that Gambling and Adult entertainment are on by default, matching CONST.POLICY.DEFAULT_PROHIBITED_EXPENSES.
  • Split-Expenses.md referenced the old Cash expense default label, now Cash expenses.

Every feature name, tab name, section name, and button label above was verified against the live UI built from the head of #98662 (48a5628) and cross-checked against src/languages/en.ts. The rewritten articles follow docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md — a single # title plus # FAQ, task-based ## headings, and screenshot suggestions as non-rendered HTML comments. Articles that only needed navigation corrections were edited in place rather than restructured, to keep the diff reviewable.

No article was added, removed, or renamed, so docs/_data/routes.yml is unchanged and no redirects are needed.

Fixed Issues

$ #97686
$ #98699
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable. This PR only changes Markdown files under docs/articles; it ships no app code.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

AI Tests

Run locally against the changed files:

  • npm run createDocsRoutes — passed, produced no diff, so the routes file is up to date.
  • npm run spell-changed — passed, 10 files checked, 0 issues.

App unit tests, lint, and typecheck were not run: this PR changes no TypeScript, JavaScript, or configuration, only Markdown help-site articles.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

The rulesRevamp beta was removed in #98662, so the revamped
Rules and Workflows pages are now the default for every workspace. Update
the help site articles to match the shipped UI: the tabbed Rules page,
the tabbed Workflows page, and the settings that moved out of Categories
and Tags into Rules.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 11, 2026 22:27
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 11, 2026
@MelvinBot MelvinBot mentioned this pull request Sep 11, 2026
54 tasks
@github-actions github-actions Bot changed the title Docs updates for E/A#98662 Tabbed Rules and Workflows help site updates [No QA] Docs updates for E/A#98662 Tabbed Rules and Workflows help site updates Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants