Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Do we need the QA for this PR? I think we don't need it. We can test this in Do we need to update the The built-in `parseExpensiMark` parser accepts an optional `maxLength` argument. It defaults to 4,000 characters, so existing callers keep the current bounded behavior. Applications that have a different safe limit can pass that limit explicitly from a worklet parser:
function parser(input: string) {
'worklet';
return parseExpensiMark(input, 10000);
} |
I think we should |
linhvovan29546
left a comment
There was a problem hiding this comment.
A minor NIT #775 (comment). All good
Explain the default and configurable input lengths and require expensify-common 2.0.201 or newer.
|
Updated the |
|
@JS00001 All yours. |
|
@Uzaifm127 I think we need one more PR to use the new version, right? |
|
@JS00001 Yes we need one more App PR in which we will be doing the version bump and passing the |
Details
parseExpensiMark()usesExpensiMarkfromexpensify-commonto convert Markdown into formatted ranges.This PR makes the parser length configurable while keeping the existing 4,000-character limit as the default by adding an optional argument to
parseExpensiMarkfunction. It also updatesexpensify-commonto2.0.201, which contains the optimizedExpensiMarkimplementation required by this parser.Related Issues
Expensify/App#95210
Manual Tests
N/A
Linked PRs