Skip to content

Title the bind tool "ExpressLRS Bind" and show its version like the main tool - #26

Open
jurgelenas wants to merge 2 commits into
unified-lua-lspfrom
bind-tool-title-exit
Open

jurgelenas wants to merge 2 commits into
unified-lua-lspfrom
bind-tool-title-exit

Conversation

@jurgelenas

Copy link
Copy Markdown
Member

No description provided.

@CapnBry CapnBry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you adding the version number to the exit line like the main tool lua does, as well as making them consistent.

The colorlcd "Lua script version" doesn't line up with the rest of the fields though and I don't think we should even include it. The B&W version has the exit bar so it comes for free and putting the version on here just craps up the UI with unnecessary noise.

The title bar rename. I know you had to rename the tool from "ELRS Bind Tool" to "ExpressLRS Bind" so it has the same name on B&W but I do hate this name for sounding like caveman name. If you don't like "ExpressLRS Bind Phrase" for the colorlcd title row how about "ExpressLRS Bind Tool" for the title instead? (Not the script name I just mean the text on the top of the screen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants