Add PREV_PAGE/NEXT_PAGE cursor nagivation to BW text fields - #28
Merged
Merged
Conversation
killEvents() refuses to mask KEY_ENTER for Lua scripts (api_general.cpp:1699), so a long ENTER is always followed by a break when the key is released. The editor acted on EVT_VIRTUAL_ENTER_LONG and that break then leaked: a long press on a space committed and the break reached the caller's row handler, which reopened the editor, and a case toggle also advanced the cursor. Record the long press instead and run its action on the following break, which consumes it. Case toggling moves into _toggleCase().
Member
Author
|
@CapnBry little side quest EdgeTX/edgetx#7802... Our Lua text edit must work the same as the native one! |
CapnBry
approved these changes
Sep 20, 2026
CapnBry
left a comment
CapnBry
left a comment
Member
There was a problem hiding this comment.
Looks like we got some extra fixes on this that I didn't consider when I suggested code, looks good! Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.