Skip to content

ci: authenticate cosign's ECR reads #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinnsc merged 1 commit into from
Oct 1, 2026
Merged

ci: authenticate cosign's ECR reads #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/promote-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,15 @@ jobs:
- name: Log in to ECR Public
run: |
set -euo pipefail
aws ecr-public get-login-password --region us-east-1 \
| skopeo login public.ecr.aws -u AWS --password-stdin
# Both credential stores: skopeo reads containers/auth.json, while
# cosign (go-containerregistry) reads ~/.docker/config.json. Without
# the docker login, cosign's signature read goes out ANONYMOUSLY and
# shares ECR Public's per-IP anonymous quota with every other GitHub
# runner — three "Data limit exceeded" failures on 2026-09-30.
TOKEN=$(aws ecr-public get-login-password --region us-east-1)
skopeo login public.ecr.aws -u AWS --password-stdin <<< "$TOKEN"
docker login public.ecr.aws -u AWS --password-stdin <<< "$TOKEN"
unset TOKEN

- name: Promote ECR Public (shared per-registry rules)
uses: ./.github/actions/promote-registry
Expand All @@ -339,7 +346,7 @@ jobs:
if: always()
run: |
skopeo logout ghcr.io || true
skopeo logout public.ecr.aws || true
skopeo logout public.ecr.aws || true; docker logout public.ecr.aws >/dev/null 2>&1 || true

- name: Summarise for the release checklist
if: always()
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/release-dev-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,15 @@ jobs:
- name: Log in to ECR Public
run: |
set -euo pipefail
aws ecr-public get-login-password --region us-east-1 \
| skopeo login public.ecr.aws -u AWS --password-stdin
# Both credential stores: skopeo reads containers/auth.json, while
# cosign (go-containerregistry) reads ~/.docker/config.json. Without
# the docker login, cosign's signature read goes out ANONYMOUSLY and
# shares ECR Public's per-IP anonymous quota with every other GitHub
# runner — three "Data limit exceeded" failures on 2026-09-30.
TOKEN=$(aws ecr-public get-login-password --region us-east-1)
skopeo login public.ecr.aws -u AWS --password-stdin <<< "$TOKEN"
docker login public.ecr.aws -u AWS --password-stdin <<< "$TOKEN"
unset TOKEN

- name: Propagate to ECR Public
uses: ./.github/actions/promote-registry
Expand All @@ -495,7 +502,7 @@ jobs:
if: always()
run: |
skopeo logout ghcr.io || true
skopeo logout public.ecr.aws || true
skopeo logout public.ecr.aws || true; docker logout public.ecr.aws >/dev/null 2>&1 || true

- name: Summarise
if: always()
Expand Down
Loading