Skip to content

test: replace unit tests with component tests #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FERNman merged 1 commit into from
Apr 16, 2026
Merged

test: replace unit tests with component tests #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Run lint
run: npm run lint
- name: Run tests
run: npm run test
run: npm run test -- --no-watch --no-progress --browsers=ChromeHeadless
- name: Upload test results
uses: actions/upload-artifact@v4
with:
Expand Down
11 changes: 6 additions & 5 deletions angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@
}
},
"test": {
"builder": "@angular-builders/jest:run",
"builder": "@angular-devkit/build-angular:karma",
"options": {
"configPath": "jest.config.js",
"projects": ["projects/angular-google-charts"],
"coverageDirectory": "../../coverage"
"polyfills": ["zone.js", "zone.js/testing"],
"tsConfig": "projects/angular-google-charts/tsconfig.spec.json",
"karmaConfig": "projects/angular-google-charts/karma.conf.js",
"include": ["../tests/**/*.spec.ts"],

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test target’s include glob looks incorrect: "../tests/**/*.spec.ts" resolves outside projects/angular-google-charts (and potentially outside the repo), so Karma may discover zero specs. Point this at the actual test folder (e.g. tests/**/*.spec.ts if resolved from the project root, or projects/angular-google-charts/tests/**/*.spec.ts if resolved from the workspace root) so the new component/integration specs are executed in CI.

Suggested change
"include": ["../tests/**/*.spec.ts"],
"include": ["projects/angular-google-charts/tests/**/*.spec.ts"],

Copilot uses AI. Check for mistakes.
"main": "projects/angular-google-charts/tests/setup.ts"
}
},
"lint": {
Expand Down Expand Up @@ -59,7 +61,6 @@
"scripts": []
},
"configurations": {
"sourceMap": true,
"legacy": {
"main": "projects/playground/src/main.modules.ts",
"tsConfig": "projects/playground/tsconfig.modules.json"
Expand Down
Loading
Loading