docs: accept ADR 0058 on the bind of the identity subject to the account at login - #2099
Merged
Merged
Conversation
…ount at login Record the bind of the identity subject to the account at the first login that presents an identity token, and the device registration that reads it. Correct ADR 0039 residuals E2 and E4 to the code of PR 2092, amend ADR 0039 D2, and add the single-use rule to the blueprint. Part of #2012.
FSM1
marked this pull request as ready for review
September 29, 2026 21:22
…ject-account-bind # Conflicts: # blueprint/api.md # decisions/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
Summary
identity_subjects.identifier_displayagain on 2026-09-29. The truncated identifier that the settings pane shows comes fromauth_methods.identifier_display, which does not change.users.identity_subject_id(unique, one subject per account). D2 makes a login that follows an identity exchange present the identity token and bind an unbound account to an unbound subject. D3 makes a device registration refuse an unbound account and a token of another subject.blueprint/api.md: "Identity and auth" gets one fact line for the single-use rule, and "Data model (complete)" namesspent_identity_tokens (token_id, expires_at). The bind is not built, so the blueprint does not describe it. The slice that builds the bind adds it (Consequence 1).Test plan
pnpm lint:mdnpx prettier --check "decisions/*.md" "blueprint/*.md"pnpm lint:tracker-refsPart of #2012.
Note
Add proposed ADR 0058 binding the identity subject to the account at login
Macroscope summarized d51410b.