Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When USB enumeration changes across boots, an enabled saved section can refer to an absent modem or an AT port now owned by another modem. This PR requires current device presence before starting dialing and disables stale sections, including with
block_auto_probe=1.Related to #280. This is an alternative to the configuration migration approach in #285: slot configurations remain independent, without serial/VID/PID matching, cross-slot merging, or APN migration. A historical section may remain in UCI, but it must not keep dialing after its device disappears.
Changes
associated_usbmappings and nested QMI data interfaces are supported.block_auto_probeblocks discovery/configuration probing, while presence checks and removal handling remain active. Fixed/manual configurations are checked without rediscovering their settings.Validation
PASS locally: host compilation of scanner/client; new presence/lifecycle tests; existing scheduler, modem netdev, bridge passthrough, core command and vendor command boundary tests; BusyBox ash syntax checks;
git diff --check.The new tests cover boot admission, tty reuse, same-slot re-enumeration, PCIe association, nested QMI, manual/fixed configurations, stale-event cancellation, commit failure, cleanup retries, AT admission and cleanup without SIM queries. UCI/sysfs/procd are fixtures: these results are not physical modem or real procd validation.
Hardware testing is requested, especially on the reported Orange Pi Zero 3 multi-modem setup. Update both
qmodemandmodem_scanfrom this branch. This PR targetsmain; astablebackport is not included. The issue should remain open pending hardware results.