Repository navigation
Maint decoders - #724
Merged
Merged
Maint decoders#724
Conversation
AhmetNSimsek
marked this pull request as ready for review
September 1, 2026 13:48
This was referenced Sep 1, 2026
Draft
AhmetNSimsek
marked this pull request as draft
September 15, 2026 11:50
AhmetNSimsek
commented
Sep 16, 2026
AhmetNSimsek
marked this pull request as ready for review
September 16, 2026 13:15
xgui3783
approved these changes
Sep 16, 2026
xgui3783
left a comment
Member
There was a problem hiding this comment.
If you have tested enough, then go for it.
My concern is commented.
Introduce Decoder class and streamline how the usage of bytes or file
AhmetNSimsek
force-pushed
the
maint_decoders
branch
from
September 28, 2026 13:44
55b3d28 to
a2db971
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
+ Coverage 45.94% 46.21% +0.27%
==========================================
Files 74 74
Lines 8371 8393 +22
==========================================
+ Hits 3846 3879 +33
+ Misses 4525 4514 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors retrieval decoders to support both file- and byte-based decoding.
Key changes:
Decoderabstraction withFILEandBYTESinput modes..nii.gz,.csv.gz) are handled natively by their underlying readers when given a file path.find_suitable_decoder()as a backwards-compatible wrapper aroundDecoder.from_filename().ZipfileConnectorto useZipfileRequestdirectly instead of the bespokeZipFileLoader, which was passing raw bytes toFILE-type decoders.ZipfileRequestcorrectly handles both decoder modes:BYTESdecoders receive in-memory bytes, whileFILEdecoders have the zip member extracted to the siibra cache first and receive the path.RepositoryConnector.get_loaderto pass the resolvedDecoderdirectly toHttpRequestrather than wrapping it in a lambda, which also caused raw bytes to be passed toFILE-type decoders.ZipfileRequestmember matching from suffix-based to exact name matching, consistent with howZipfileConnector.search_filesreturns full member paths.Custom
func=callbacks retain the existing byte-based behaviour.