Repository navigation
Maint: allow building objects outside of designated conf folders - #725
Draft
AhmetNSimsek wants to merge 2 commits into
Draft
AhmetNSimsek wants to merge 2 commits into
AhmetNSimsek wants to merge 2 commits into
Conversation
AhmetNSimsek
force-pushed
the
maint_build_objects
branch
from
August 28, 2026 16:05
ccb54b3 to
7d6ac31
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
- Coverage 46.21% 46.20% -0.01%
==========================================
Files 74 74
Lines 8393 8390 -3
==========================================
- Hits 3879 3877 -2
+ Misses 4514 4513 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AhmetNSimsek
force-pushed
the
maint_build_objects
branch
4 times, most recently
from
September 30, 2026 14:47
9c93dcd to
08a1db5
Compare
AhmetNSimsek
force-pushed
the
maint_build_objects
branch
from
October 12, 2026 12:54
08a1db5 to
8294254
Compare
AhmetNSimsek
force-pushed
the
maint_build_objects
branch
from
October 22, 2026 10:55
8294254 to
8a328f9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes configuration loading independent of the directory layout while preserving the existing folder-based fast path.
Configuration.build_objects()now accepts an optional expected class. If the configured folder exists, objects are loaded exactly as before. If it is missing, the loader falls back to all discovered configuration specs and keeps only objects matching the requested class.Related changes:
RepositoryConnectorfor file discovery and keepConfigurationresponsible for selecting relevant specs;Factoryresponsible solely for constructing objects;build_objects();This keeps standard siibra configurations fast while allowing valid configuration JSON files to be placed in arbitrary directories.