Repository navigation
feat: tell the attestation service how a client compressed its batches - #211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ten seconds after a player logged in, the server asks the attestation service a second time, with counts of how the client compressed its first batches (Falcon-MC/Network#19). Like the first question, it only runs when
allow-unofficial-clientsis false, never blocks, and an answer that is late or missing changes nothing.NetworkHandler::getBatchTraitsreads the counts the io thread samples once a second, next to the ping.ClientAttestation::inspectSessionsends them as a new evidence section. What they mean for a verdict stays in the service.It needs Falcon-MC/Network at
main(#19): an existing build directory has to be configured again to fetch it.Not built in full here: the three changed sources were only checked with the project's compile flags against the new Network headers. Not tested on a running server.
Test plan:
Client noteline or a removal follows about ten seconds after login.AI disclosure
Written by Claude Fable 5.2 (research in the 1.26.60 client with IDA, code).