Repository navigation
feat: pass a client's candidates and channels to the attestation service - #215
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evidence a server sends about a NetherNet client gets two more sections (Falcon-MC/Network#20):
v4orv6), as is already done for candidates written in the offerThe candidates are cut at 2 KiB so the whole evidence stays under what the service accepts. What these sections mean stays in the service.
It needs Falcon-MC/Network at
main(#20): an existing build directory has to be configured again.Checked by compiling
ClientAttestation.cppwith the project's flags against the new Network headers. No full build, not tested on a running server.Test plan: join with the game with
allow-unofficial-clients=false; the player must get in as before, with noClient noteline.AI disclosure
Written by Claude Fable 5.2 (code).