Repository navigation
feat(gametest): give the sculk catalyst its spreader and bind SculkSpreader - #385
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SculkCatalystBlockand itsSculkCatalystblock actor, holding aSculkSpreader(charge cursors).cursorslist written only when not empty;x/y/zints,charge/update/decay/facingshorts; loaded only into an empty spreader, at most 32 cursors.addCursors: the charge is split into cursors of at most 1000; a part past 32 cursors is dropped. A new cursor has update 0, decay 1, facing -1.Test.getSculkSpreader(structure block check first,undefinedwhen the block holds no catalyst) and theSculkSpreaderclass:maxCharge(1000, 0 once the catalyst is gone),addCursorsWithOffset(floored offset added to the catalyst position),getCursorPosition(origin past the last cursor),getNumberOfCursors,getTotalCharge. The catalyst is looked up again on every call, as the game does.These members were listed in the surface table but had no binding:
test.getSculkSpreaderwasundefined.How it was checked
Each value was read in the 26.60 Windows client: the GameTest helper binding, the catalyst block actor constructor/save/load and the spreader cursor save/load.
Syntax-checked locally;
script-api-gametestgains a spreader save/load check and a GameTest using a server-placed catalyst.Not done here: the cursors do not move yet (the catalyst tick, the spread through sculk and veins, and the bloom on mob death are not ported).
AI disclosure
Written by Claude Opus 5.5 (claude-opus-5-5): research in the game client, code and tests.