Repository navigation
fix(script): read vanilla vibration flags in BlockVibrationPropertiesComponent - #386
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BlockVibrationPropertiesComponent.getCanDampenVibrations/getCanOccludeVibrationsread only a pack block's json, so vanilla wool and carpets answeredfalsewhile the vibration system treats them as dampening (and wool as occluding).The game reads one component for both: the script getters and the vibration listener/occlusion code call the same block component lookup (bit 0 dampen, bit 1 occlude, default off). The getters now use
VibrationProperties::of, the flags the engine already uses.How it was checked
26.60 Windows client: the two script getters and their callers' shared component lookup. Syntax-checked locally;
ScriptBlockRecipeTestsnow checks wool (true:true) and white carpet (true:false).AI disclosure
Written by Claude Opus 5.5 (claude-opus-5-5): research in the game client, code and tests.