Repository navigation
fix: send one radii pair for primitive shape cylinders - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The 26.60 client stores a primitive shape cylinder as one
Vec2of radii (bottom, top), a height and a segment count: the payload builder of the cylinder shape (sub_14B8E7B80, 26.60) copies 8 bytes of radii, a float and a byte into the variant. The packet wrote twoVec2radii, eight bytes too many, which misaligns every later shape in the packet.DebugShapeData: the cylinder reusesmRadii2flike the cone;mRadiusXandmRadiusZare gone.How it is verified
New
primitive-shapestest: a cylinder followed by a removal encodes to the expected size with the radii right after the variant index, and decodes back. All five protocol tests pass.AI disclosure
Written by Claude Opus 5.5 (claude-opus-5-5), checked against the 26.60 client in IDA.