Repository navigation
Replace GitRepository .git-internals parsing with LibGit2Sharp #352
Description
Tier 1 — Replace. src/Fallout.Build/VCS/GitRepository.cs (~268 LOC) hand-parses git internals — .git/config, .git/HEAD, packed-refs — and uses a regex to crack remote URLs (HTTPS/SSH). This is the single most fragile spot found in the audit: it breaks if git changes its on-disk format.
Replace with
LibGit2Sharp — the standard .NET libgit2 binding. Eliminates manual packed-refs/config parsing and the URL regex (use Uri).
Scope
src/Fallout.Build/VCS/GitRepository.cs—FromLocalDirectory(),GetRemoteConnectionFromUrl(),GetRemoteConnectionFromConfig()- Keep
GitRepositoryExtensions.cs(simple branch-name comparisons) as-is.
Non-breaking
Wrap LibGit2Sharp behind the existing GitRepository public surface — additive, no consumer signature changes. Target the 2026 line directly.
Acceptance
-
.gitfile/regex parsing removed; introspection backed by LibGit2Sharp - Public
GitRepositoryAPI unchanged (verified against call sites) - Existing VCS tests green; add cases for SSH/HTTPS/UNC remotes
From dependency-consolidation audit, 2026-06-02.
Activity
ChrisonSimtian commentedon Jun 3, 2026
Insights from a discarded prototype (it forked the pre-rearchitecture tree, so paths are old — map to the renamed onion structure after #359).
FromLocalDirectory: useRepositoryfor head/commit/branch/tags/tracked-remote/URL. Drops manual.git/config,HEAD,packed-refsparsing + the URL regex.Uriplus a small SCP-like (git@host:path) fallback — plainUriwon't parse SCP syntax.file://, UNC (\server\share\repo.git). Prototype: 26/26 green.robvanuden commentedon Jun 8, 2026
Will this make it work in worktrees as well?
ChrisonSimtian commentedon Jun 16, 2026
yes, LibGit2Sharp probably does a way better job out of the box than we could do maintaining this ourselves.
So in short, less code to maintain while also gaining new features/fixing existing bugs ;-)
Only worry atm is what if they cease development. But I think at that point we would just fork it and maintain it ourselves and return back to status quo (o: