Repository navigation
Adopt MoreLINQ; remove duplicated collection extensions #355
Description
Tier 2 — Consolidate. src/Fallout.Utilities/Collections/ (~900 LOC, 23 files) contains many LINQ-like helpers that duplicate MoreLINQ: Enumerable.Distinct.cs (DistinctBy), Enumerable.Random.cs (Random/Shuffle), Enumerable.TakeUntil.cs, Enumerable.ForEach.cs.
Action
Add MoreLINQ; delete the duplicated helpers and redirect call sites.
Keep (genuinely Fallout-specific — do NOT delete)
Enumerable.TopologicalSort.cs(cycle-detecting sort used for target ordering)LookupTable.cs(mutableILookup— no BCL/MoreLINQ equivalent)Enumerable.SingleOrDefaultOrError.cs/Enumerable.ToDictionary.cs(custom diagnostic messages)
⚠️ Breaking change
These are public extension methods. Removal breaks consumers → breaking-change, experimental, batched to yearly major, CHANGELOG migration note. Where feasible, keep [Obsolete] forwarders.
Acceptance
- MoreLINQ added to
Directory.Packages.props - Duplicated
Distinct/Random/TakeUntil/ForEachhelpers removed or obsoleted - Fallout-specific helpers retained
- CHANGELOG entry + migration note
From dependency-consolidation audit, 2026-06-02.
Activity
ChrisonSimtian commentedon Jun 3, 2026
Insights from a discarded prototype (old paths; map to onion structure after #359).
DistinctByandShuffle(wasRandomize). Replace via[Obsolete]forwarders.TakeUntil/SkipUntil: ours is EXCLUSIVE, MoreLINQ's is INCLUSIVE. Swapping silently changes ArgumentParser + CompletionUtility.ForEach/ForEachLazy: MoreLINQ has noAction<T,int>index overload and noForEachLazy; ~70 callers.Random<T>(): no MoreLINQ/BCL equivalent.DistinctBy/Shuffle, which collide with MoreLINQ's extensions. CallMoreLinq.MoreEnumerable.*explicitly so both netstandard2.0 and net10.0 resolve.