Repository navigation
Document keep-rationale for justified hand-rolled code (crypto, paths, CI writers, schema) #358
Description
Tier 3 — Keep, but document. The audit confirmed several hand-rolled areas are justified. Record the rationale (code comments + a short docs/ note) so they aren't re-litigated in future "use a library" passes.
Keep + reason
Security/EncryptionUtility.cs— AES-GCM + PBKDF2, OWASP-aligned, security-audited (Security audit: pen-test EncryptionUtility (the existing 'v1:' secret format) #212). Correct BCL crypto; no swap.IO/AbsolutePath.*+PathConstruction.cs(~500 LOC) — type-safe, OS-independent path API; a core selling point. BCL paths are string-typed and OS-dependent.- CI config writers —
CICD/CustomFileWriter.cs+ ~1,800 LOC of*Configuration.cs. TeamCity/SpaceAutomation emit Kotlin DSL (YamlDotNet can't help); YAML targets need exact comment/quote/indent control a serializer would silently change. SchemaUtility.cs(~393 LOC) — emits the legacy NJsonSchema-shaped envelope consumed byFallout.Cli; the exact output shape is a contract.
Acceptance
- Brief "why hand-rolled" note added to each area (XML-doc or header comment)
- Short
docs/entry (or section in conventions) listing these deliberate keeps
From dependency-consolidation audit, 2026-06-02.
Activity
ChrisonSimtian commentedon Jun 3, 2026
Insights from a discarded prototype (old paths; map to onion structure after #359).
docs/dependencies-kept.md, cross-linked fromdocs/dependencies.md.dennisdoomen commentedon Jun 6, 2026
Good to know that I at some point decided to extract the path idea into https://github.com/dennisdoomen/pathy/
ChrisonSimtian commentedon Jun 18, 2026
thats actually what triggered me to look into it. But Claude reckons that would be the only one it cant use ... But I dont trust it with this judgement call. Either way I think its worth to look into this and stop reinventing the wheel. The less code we maintain the better (i.e. the more time we have to focus on what we actually want to deliver ;-) )
dennisdoomen commentedon Jun 19, 2026
I'm just saying that I liked the idea that Nuke offered and decided to extract the idea as a standalone source-only nuget package. It's not 100% compatible to Nuke's. So I would just keep it as is.