Repository navigation
Conversation
Dependabot (Fallout-build#681) bumped the generated security-scan.yml to github/codeql-action/upload-sarif@v4, but the generator still wrote v3, so every local ./build.sh run, even --help, rewrote the file back to v3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ANcpLua
marked this pull request as ready for review
October 13, 2026 01:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the workflow generator write
github/codeql-action/upload-sarif@v4, the versionsecurity-scan.ymlalready uses.What changed
build/Build.CI.GitHubActions.cs:upload-sarif@v3→upload-sarif@v4.security-scan.ymlitself does not change.Why
#681 (Dependabot's codeql-action bump) changed the generated
security-scan.ymlto v4, but not the generator. Every local./build.shrun, even--help, rewrote the file back to v3, so contributors got an unrelated change in their working tree.Verification
develop(fcf5cbb),./build.sh --helprewritessecurity-scan.ymlfrom v4 to v3.security-scan.ymlunchanged.Notes
editing-ci-workflowsskill namesbuild.ymlandbuild-cross-platform.ymlas generated, but notsecurity-scan.yml.I can't set labels on this repo.
target/vCurrentandskip-changelogshould fit, since this is housekeeping.🤖 Generated with Claude Code