Repository navigation
Menu strip: File, Edit, Selection and View menus - #13
Merged
Merged
Conversation
The script editor's toolbar starts with the editor menu strip. Its items dispatch the editor's existing actions to the open file's view, whose panel already handles them for the context menu. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXesb588JFPYCDBnK94vn5
The menu strip uses plugin_editor_api::EditorMenuStrip and EditorMenu, which landed in Pulsar-Native with #1167 (6c61db9aa). The check still checked out 55aa2dba1, which predates them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXesb588JFPYCDBnK94vn5
Pulsar-Native 6c61db9aa (the revision the check builds against) pins SceneDB 81bb3557, and its Helio uses that revision's asset API (AssetId, register_loader, register_binding). This manifest's SceneDB patch still named 685b1b0a, so helio_component failed to compile. Cargo.lock is re-resolved by Cargo for the new pins; Gamma follows the revision plugin_editor_api now requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXesb588JFPYCDBnK94vn5
github-project-automation
Bot
moved this from In Progress
to Pending Release
in Pulsar Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Far-Beyond-Pulsar/Pulsar-Native#1012: the script editor gets its own menu strip, as the level, Blueprint, Shader and Matter editors have.
Changes
The toolbar starts with an
EditorMenuStrip:The items dispatch the editor's existing actions (
EditorUndo,EditorCut, …) to the open file's view.FilePanelalready handles those actions for its context menu, so nothing new is wired. With no file open, the items are greyed out.Not included
The rest of #1012's script editor list (multi-cursor selection, Find, Go to Line/Symbol/Definition/References) has nothing to call yet. Mockaco's
WgpuiEditorViewexposes undo/redo, cut/copy/paste, select all, unfold all andgo_to(line, column), and the plugin has no go-to-line prompt. Those menus need that API first.Checked
cargo check -p script_editor_pluginpasses in Pulsar-Native.🤖 Generated with Claude Code
https://claude.ai/code/session_01RXesb588JFPYCDBnK94vn5
Generated by Claude Code