Conversation
Member
|
Let's start winding down 2.18 branch and only backport security fixes. 2.21 may be targeted for correctness bugs like this one. |
… needed `_writeStringImpl(int, char[], int, int)` read `text[offset + len]` instead of `text[offset + i]` in the escaped basic-string branch, so any `char[]` value containing a character that needs escaping (quote, backslash, control char) was written with the wrong characters, or threw `ArrayIndexOutOfBoundsException` when the array had no trailing slack. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pjfanning
force-pushed
the
toml-char-array-string-escape
branch
from
September 13, 2026 15:34
be38036 to
f781651
Compare
Member
Author
|
retargeted to 2.21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_writeStringImpl(int, char[], int, int)readstext[offset + len]instead oftext[offset + i]in the escaped basic-string branch. SowriteString(char[], int, int)with any value containing a character that needs escaping (",\, control chars) either writes the wrong characters (the one just past the range, repeated) or throwsArrayIndexOutOfBoundsExceptionwhen the array has no slack after the range.The
Stringvariant is unaffected — this only hits streaming users of thechar[]overload, which is presumably why it went unnoticed (there were no tests for it).Spotted while working on #725. One-line fix plus a regression test that checks the
char[]output equals theStringoutput and reads back correctly. Affects all branches from 2.18 through 3.x.🤖 Generated with Claude Code